Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-23 Thread Alan Tull
On Sat, Aug 23, 2014 at 9:54 AM, Mark Brown wrote: > On Sat, Aug 23, 2014 at 07:00:44AM -0700, Guenter Roeck wrote: >> On 08/22/2014 05:31 PM, atull wrote: > >> >of_get_regulator_init_data() will only have an error if it cannot alloc >> >the regulator_init_data struct. That's why I did -ENOMEM.

Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-23 Thread Mark Brown
On Sat, Aug 23, 2014 at 07:00:44AM -0700, Guenter Roeck wrote: > On 08/22/2014 05:31 PM, atull wrote: > >of_get_regulator_init_data() will only have an error if it cannot alloc > >the regulator_init_data struct. That's why I did -ENOMEM. If there > >is no platform data and nothing about the

Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-23 Thread Guenter Roeck
On 08/22/2014 05:31 PM, atull wrote: On Fri, 22 Aug 2014, Mark Brown wrote: On Fri, Aug 22, 2014 at 04:11:33PM -0500, at...@opensource.altera.com wrote: + if (pdata && pdata->reg_init_data) { + config.init_data = pdata->reg_init_data; + } else { +

Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-23 Thread Guenter Roeck
On 08/22/2014 05:31 PM, atull wrote: On Fri, 22 Aug 2014, Mark Brown wrote: On Fri, Aug 22, 2014 at 04:11:33PM -0500, at...@opensource.altera.com wrote: + if (pdata pdata-reg_init_data) { + config.init_data = pdata-reg_init_data; + } else { +

Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-23 Thread Mark Brown
On Sat, Aug 23, 2014 at 07:00:44AM -0700, Guenter Roeck wrote: On 08/22/2014 05:31 PM, atull wrote: of_get_regulator_init_data() will only have an error if it cannot alloc the regulator_init_data struct. That's why I did -ENOMEM. If there is no platform data and nothing about the regulator

Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-23 Thread Alan Tull
On Sat, Aug 23, 2014 at 9:54 AM, Mark Brown broo...@kernel.org wrote: On Sat, Aug 23, 2014 at 07:00:44AM -0700, Guenter Roeck wrote: On 08/22/2014 05:31 PM, atull wrote: of_get_regulator_init_data() will only have an error if it cannot alloc the regulator_init_data struct. That's why I did

Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-22 Thread atull
On Fri, 22 Aug 2014, Mark Brown wrote: > On Fri, Aug 22, 2014 at 04:11:33PM -0500, at...@opensource.altera.com wrote: > > > + if (pdata && pdata->reg_init_data) { > > + config.init_data = pdata->reg_init_data; > > + } else { > > + config.init_data =

Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-22 Thread Mark Brown
On Fri, Aug 22, 2014 at 04:11:33PM -0500, at...@opensource.altera.com wrote: > + if (pdata && pdata->reg_init_data) { > + config.init_data = pdata->reg_init_data; > + } else { > + config.init_data = of_get_regulator_init_data(dev, np); > + if

[PATCH v2 1/2] pmbus: add regulator support

2014-08-22 Thread atull
From: Alan Tull To add a regulator, the pmbus device driver needs to add regulator_desc information to its pmbus_driver_info struct. The regulator_init_data can be intialized from either platform data or the device tree. Signed-off-by: Alan Tull v2: Remove '#include ' Only one regulator

Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-22 Thread atull
On Fri, 22 Aug 2014, Mark Brown wrote: On Fri, Aug 22, 2014 at 04:11:33PM -0500, at...@opensource.altera.com wrote: + if (pdata pdata-reg_init_data) { + config.init_data = pdata-reg_init_data; + } else { + config.init_data = of_get_regulator_init_data(dev, np);

[PATCH v2 1/2] pmbus: add regulator support

2014-08-22 Thread atull
From: Alan Tull at...@opensource.altera.com To add a regulator, the pmbus device driver needs to add regulator_desc information to its pmbus_driver_info struct. The regulator_init_data can be intialized from either platform data or the device tree. Signed-off-by: Alan Tull

Re: [PATCH v2 1/2] pmbus: add regulator support

2014-08-22 Thread Mark Brown
On Fri, Aug 22, 2014 at 04:11:33PM -0500, at...@opensource.altera.com wrote: + if (pdata pdata-reg_init_data) { + config.init_data = pdata-reg_init_data; + } else { + config.init_data = of_get_regulator_init_data(dev, np); + if (!config.init_data)