Re: [PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-23 Thread Jason Cooper
On Thu, Oct 23, 2014 at 03:28:45PM +0300, Dan Carpenter wrote: > On Wed, Oct 22, 2014 at 09:23:51PM -0500, Eric Rost wrote: > > Adds crypto API support for the skein module. Also collapses the > > threefish module into the skein module. > > Why is this in staging anyway? It seems very small and

Re: [PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-23 Thread Jason Cooper
On Wed, Oct 22, 2014 at 09:23:51PM -0500, Eric Rost wrote: > Adds crypto API support for the skein module. Also collapses the > threefish module into the skein module. > > Signed-off-by: Eric Rost > --- > drivers/staging/skein/Kconfig | 22 +-- > drivers/staging/skein/Makefile

Re: [PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-23 Thread Dan Carpenter
On Wed, Oct 22, 2014 at 09:23:51PM -0500, Eric Rost wrote: > Adds crypto API support for the skein module. Also collapses the > threefish module into the skein module. > Why is this in staging anyway? It seems very small and not terrible code. It could easily be sent to the main kernel. >

Re: [PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-23 Thread Dan Carpenter
On Wed, Oct 22, 2014 at 09:23:51PM -0500, Eric Rost wrote: Adds crypto API support for the skein module. Also collapses the threefish module into the skein module. Why is this in staging anyway? It seems very small and not terrible code. It could easily be sent to the main kernel. diff

Re: [PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-23 Thread Jason Cooper
On Wed, Oct 22, 2014 at 09:23:51PM -0500, Eric Rost wrote: Adds crypto API support for the skein module. Also collapses the threefish module into the skein module. Signed-off-by: Eric Rost eric.r...@mybabylon.net --- drivers/staging/skein/Kconfig | 22 +--

Re: [PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-23 Thread Jason Cooper
On Thu, Oct 23, 2014 at 03:28:45PM +0300, Dan Carpenter wrote: On Wed, Oct 22, 2014 at 09:23:51PM -0500, Eric Rost wrote: Adds crypto API support for the skein module. Also collapses the threefish module into the skein module. Why is this in staging anyway? It seems very small and not

[PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-22 Thread Eric Rost
Adds crypto API support for the skein module. Also collapses the threefish module into the skein module. Signed-off-by: Eric Rost --- drivers/staging/skein/Kconfig | 22 +-- drivers/staging/skein/Makefile| 13 ++-- drivers/staging/skein/skein.c | 1 +

[PATCH v2 1/2] staging: skein: Add Crypto API support

2014-10-22 Thread Eric Rost
Adds crypto API support for the skein module. Also collapses the threefish module into the skein module. Signed-off-by: Eric Rost eric.r...@mybabylon.net --- drivers/staging/skein/Kconfig | 22 +-- drivers/staging/skein/Makefile| 13 ++-- drivers/staging/skein/skein.c