Re: [alsa-devel] [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Bo Shen
Hi Mark, Lars-Perter, On 01/27/2015 12:49 AM, Lars-Peter Clausen wrote: On 01/26/2015 05:42 PM, Mark Brown wrote: On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: Le 16/01/2015 02:17, Bo Shen a écrit : Does this end up in the i2c_driver_id driver data or do we need some extra

Re: [alsa-devel] [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 05:42 PM, Mark Brown wrote: On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: Le 16/01/2015 02:17, Bo Shen a écrit : Does this end up in the i2c_driver_id driver data or do we need some extra code when devtype is assigned to check for an of_node and look at the DT

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Mark Brown
On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: > Le 16/01/2015 02:17, Bo Shen a écrit : > >> Does this end up in the i2c_driver_id driver data or do we need some > >> extra code when devtype is assigned to check for an of_node and look at > >> the DT data instead? That certainly

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Nicolas Ferre
Le 16/01/2015 02:17, Bo Shen a écrit : > Hi Mark, > > On 01/15/2015 07:54 PM, Mark Brown wrote: >> On Mon, Dec 15, 2014 at 11:31:11AM +0800, Bo Shen wrote: >> >>> +#ifdef CONFIG_OF >>> +static enum wm8904_type wm8904_data = WM8904; >>> +static enum wm8904_type wm8912_data = WM8912; >>> + >>>

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Nicolas Ferre
Le 16/01/2015 02:17, Bo Shen a écrit : Hi Mark, On 01/15/2015 07:54 PM, Mark Brown wrote: On Mon, Dec 15, 2014 at 11:31:11AM +0800, Bo Shen wrote: +#ifdef CONFIG_OF +static enum wm8904_type wm8904_data = WM8904; +static enum wm8904_type wm8912_data = WM8912; + +static const struct

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Mark Brown
On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: Le 16/01/2015 02:17, Bo Shen a écrit : Does this end up in the i2c_driver_id driver data or do we need some extra code when devtype is assigned to check for an of_node and look at the DT data instead? That certainly used to be

Re: [alsa-devel] [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 05:42 PM, Mark Brown wrote: On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: Le 16/01/2015 02:17, Bo Shen a écrit : Does this end up in the i2c_driver_id driver data or do we need some extra code when devtype is assigned to check for an of_node and look at the DT

Re: [alsa-devel] [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Bo Shen
Hi Mark, Lars-Perter, On 01/27/2015 12:49 AM, Lars-Peter Clausen wrote: On 01/26/2015 05:42 PM, Mark Brown wrote: On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: Le 16/01/2015 02:17, Bo Shen a écrit : Does this end up in the i2c_driver_id driver data or do we need some extra

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-15 Thread Bo Shen
Hi Mark, On 01/15/2015 07:54 PM, Mark Brown wrote: On Mon, Dec 15, 2014 at 11:31:11AM +0800, Bo Shen wrote: +#ifdef CONFIG_OF +static enum wm8904_type wm8904_data = WM8904; +static enum wm8904_type wm8912_data = WM8912; + +static const struct of_device_id wm8904_of_match[] = { + { +

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-15 Thread Mark Brown
On Mon, Dec 15, 2014 at 11:31:11AM +0800, Bo Shen wrote: > +#ifdef CONFIG_OF > +static enum wm8904_type wm8904_data = WM8904; > +static enum wm8904_type wm8912_data = WM8912; > + > +static const struct of_device_id wm8904_of_match[] = { > + { > + .compatible = "wlf,wm8904", > +

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-15 Thread Bo Shen
Hi Mark, On 01/15/2015 07:54 PM, Mark Brown wrote: On Mon, Dec 15, 2014 at 11:31:11AM +0800, Bo Shen wrote: +#ifdef CONFIG_OF +static enum wm8904_type wm8904_data = WM8904; +static enum wm8904_type wm8912_data = WM8912; + +static const struct of_device_id wm8904_of_match[] = { + { +

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-15 Thread Mark Brown
On Mon, Dec 15, 2014 at 11:31:11AM +0800, Bo Shen wrote: +#ifdef CONFIG_OF +static enum wm8904_type wm8904_data = WM8904; +static enum wm8904_type wm8912_data = WM8912; + +static const struct of_device_id wm8904_of_match[] = { + { + .compatible = wlf,wm8904, +

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-13 Thread Nicolas Ferre
Le 15/12/2014 04:31, Bo Shen a écrit : > From: Alexander Morozov > > Signed-off-by: Alexander Morozov > [Add driver data to distinguish device type] > Signed-off-by: Bo Shen > --- > > Changes in v2: > - Add driver data for distinguish the device capability. > > sound/soc/codecs/wm8904.c |

Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-13 Thread Nicolas Ferre
Le 15/12/2014 04:31, Bo Shen a écrit : From: Alexander Morozov li...@meltdown.ru Signed-off-by: Alexander Morozov li...@meltdown.ru [Add driver data to distinguish device type] Signed-off-by: Bo Shen voice.s...@atmel.com --- Changes in v2: - Add driver data for distinguish the device

[PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2014-12-14 Thread Bo Shen
From: Alexander Morozov Signed-off-by: Alexander Morozov [Add driver data to distinguish device type] Signed-off-by: Bo Shen --- Changes in v2: - Add driver data for distinguish the device capability. sound/soc/codecs/wm8904.c | 22 ++ 1 file changed, 22 insertions(+)

[PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2014-12-14 Thread Bo Shen
From: Alexander Morozov li...@meltdown.ru Signed-off-by: Alexander Morozov li...@meltdown.ru [Add driver data to distinguish device type] Signed-off-by: Bo Shen voice.s...@atmel.com --- Changes in v2: - Add driver data for distinguish the device capability. sound/soc/codecs/wm8904.c | 22