Re: [PATCH v2 1/3] io-64-nonatomic: add io{read|write}64[be] macros

2017-06-28 Thread Logan Gunthorpe
On 28/06/17 04:11 AM, Arnd Bergmann wrote: > This is wrong since ioread* is not the same read* on x86 and other > architectures that have native PCI PIO accessors, or that require > additional barriers for those. > > You have to copy hi_lo_readq() here, and call ioread32 twice instead > of

Re: [PATCH v2 1/3] io-64-nonatomic: add io{read|write}64[be] macros

2017-06-28 Thread Logan Gunthorpe
On 28/06/17 04:11 AM, Arnd Bergmann wrote: > This is wrong since ioread* is not the same read* on x86 and other > architectures that have native PCI PIO accessors, or that require > additional barriers for those. > > You have to copy hi_lo_readq() here, and call ioread32 twice instead > of

Re: [PATCH v2 1/3] io-64-nonatomic: add io{read|write}64[be] macros

2017-06-28 Thread Arnd Bergmann
On Wed, Jun 28, 2017 at 1:02 AM, Logan Gunthorpe wrote: > This patch adds io{read|write}64[be] macros to point to the readq/writeq > in use. > > This is because new drivers are encouraged to use ioreadXX, et al instead > of readX[1], et al -- and mixing ioreadXX with readq is

Re: [PATCH v2 1/3] io-64-nonatomic: add io{read|write}64[be] macros

2017-06-28 Thread Arnd Bergmann
On Wed, Jun 28, 2017 at 1:02 AM, Logan Gunthorpe wrote: > This patch adds io{read|write}64[be] macros to point to the readq/writeq > in use. > > This is because new drivers are encouraged to use ioreadXX, et al instead > of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. > > [1]

[PATCH v2 1/3] io-64-nonatomic: add io{read|write}64[be] macros

2017-06-27 Thread Logan Gunthorpe
This patch adds io{read|write}64[be] macros to point to the readq/writeq in use. This is because new drivers are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] ldd3: section 9.4.2 Signed-off-by: Logan Gunthorpe

[PATCH v2 1/3] io-64-nonatomic: add io{read|write}64[be] macros

2017-06-27 Thread Logan Gunthorpe
This patch adds io{read|write}64[be] macros to point to the readq/writeq in use. This is because new drivers are encouraged to use ioreadXX, et al instead of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. [1] ldd3: section 9.4.2 Signed-off-by: Logan Gunthorpe cc: Christoph