Re: [PATCH v2 1/4] fs: fix data invalidation in the cleancache during direct IO

2017-04-25 Thread Jan Kara
On Mon 24-04-17 19:41:32, Andrey Ryabinin wrote: > Some direct IO write fs hooks call invalidate_inode_pages2[_range]() > conditionally iff mapping->nrpages is not zero. This can't be right, > because invalidate_inode_pages2[_ragne]() also invalidate data in > the cleancache via

Re: [PATCH v2 1/4] fs: fix data invalidation in the cleancache during direct IO

2017-04-25 Thread Jan Kara
On Mon 24-04-17 19:41:32, Andrey Ryabinin wrote: > Some direct IO write fs hooks call invalidate_inode_pages2[_range]() > conditionally iff mapping->nrpages is not zero. This can't be right, > because invalidate_inode_pages2[_ragne]() also invalidate data in > the cleancache via

[PATCH v2 1/4] fs: fix data invalidation in the cleancache during direct IO

2017-04-24 Thread Andrey Ryabinin
Some direct IO write fs hooks call invalidate_inode_pages2[_range]() conditionally iff mapping->nrpages is not zero. This can't be right, because invalidate_inode_pages2[_ragne]() also invalidate data in the cleancache via cleancache_invalidate_inode() call. So if page cache is empty but there is

[PATCH v2 1/4] fs: fix data invalidation in the cleancache during direct IO

2017-04-24 Thread Andrey Ryabinin
Some direct IO write fs hooks call invalidate_inode_pages2[_range]() conditionally iff mapping->nrpages is not zero. This can't be right, because invalidate_inode_pages2[_ragne]() also invalidate data in the cleancache via cleancache_invalidate_inode() call. So if page cache is empty but there is