Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread jacopo mondi
Hi Hans, On Thu, Mar 15, 2018 at 08:30:21AM -0700, Hans Verkuil wrote: > On 03/15/2018 07:38 AM, jacopo mondi wrote: > > Hi Sakari, > >thanks for looking into this! > > > > On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: > >> Hi Jacopo, > >> > >> I wonder if it'd make sense to

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread jacopo mondi
Hi Hans, On Thu, Mar 15, 2018 at 08:30:21AM -0700, Hans Verkuil wrote: > On 03/15/2018 07:38 AM, jacopo mondi wrote: > > Hi Sakari, > >thanks for looking into this! > > > > On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: > >> Hi Jacopo, > >> > >> I wonder if it'd make sense to

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread Hans Verkuil
On 03/15/2018 07:38 AM, jacopo mondi wrote: > Hi Sakari, >thanks for looking into this! > > On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: >> Hi Jacopo, >> >> I wonder if it'd make sense to just make all the changes to the driver and >> then have it reviewed; I'm not sure the

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread Hans Verkuil
On 03/15/2018 07:38 AM, jacopo mondi wrote: > Hi Sakari, >thanks for looking into this! > > On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: >> Hi Jacopo, >> >> I wonder if it'd make sense to just make all the changes to the driver and >> then have it reviewed; I'm not sure the

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread jacopo mondi
Hi Sakari, thanks for looking into this! On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > I wonder if it'd make sense to just make all the changes to the driver and > then have it reviewed; I'm not sure the old driver can be said to have been > in a known-good

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread jacopo mondi
Hi Sakari, thanks for looking into this! On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > I wonder if it'd make sense to just make all the changes to the driver and > then have it reviewed; I'm not sure the old driver can be said to have been > in a known-good

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread Sakari Ailus
Hi Jacopo, I wonder if it'd make sense to just make all the changes to the driver and then have it reviewed; I'm not sure the old driver can be said to have been in a known-good state that'd be useful to compare against. I think you did that with another driver as well. On Mon, Mar 12, 2018 at

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread Sakari Ailus
Hi Jacopo, I wonder if it'd make sense to just make all the changes to the driver and then have it reviewed; I'm not sure the old driver can be said to have been in a known-good state that'd be useful to compare against. I think you did that with another driver as well. On Mon, Mar 12, 2018 at

[PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-12 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-12 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi ---