Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Am Donnerstag, 25. Dezember 2014, 08:46:08 schrieb Roger: > Hi! Heiko > > Any suggestion? Follow the suggestions from Chen-Yu Tsai (and me) :-) . I.e. use the phy-reset support the stmmac already provides and control power stuff using the regulator framework even if it's only a gpio-controlled

Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Am Donnerstag, 25. Dezember 2014, 08:46:08 schrieb Roger: Hi! Heiko Any suggestion? Follow the suggestions from Chen-Yu Tsai (and me) :-) . I.e. use the phy-reset support the stmmac already provides and control power stuff using the regulator framework even if it's only a gpio-controlled

Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Hi, On Wed, Dec 3, 2014 at 3:57 PM, Roger wrote: > Hi! Heiko > > about regulator, power gpio, reset gpio and irq gpio > please refer to my comment inline, tks. > > > On 2014/12/2 7:44, Heiko Stübner wrote: >> >> Hi Roger, >> >> the comments inline are a rough first review. I hope to get a

Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Hi! Heiko Any suggestion? On 2014/12/3 15:57, Roger wrote: Hi! Heiko about regulator, power gpio, reset gpio and irq gpio please refer to my comment inline, tks. On 2014/12/2 7:44, Heiko Stübner wrote: Hi Roger, the comments inline are a rough first review. I hope to get a clearer

Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Hi! Heiko Any suggestion? On 2014/12/3 15:57, Roger wrote: Hi! Heiko about regulator, power gpio, reset gpio and irq gpio please refer to my comment inline, tks. On 2014/12/2 7:44, Heiko Stübner wrote: Hi Roger, the comments inline are a rough first review. I hope to get a clearer

Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Hi, On Wed, Dec 3, 2014 at 3:57 PM, Roger roger.c...@rock-chips.com wrote: Hi! Heiko about regulator, power gpio, reset gpio and irq gpio please refer to my comment inline, tks. On 2014/12/2 7:44, Heiko Stübner wrote: Hi Roger, the comments inline are a rough first review. I hope to

Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Hi! Heiko about regulator, power gpio, reset gpio and irq gpio please refer to my comment inline, tks. On 2014/12/2 7:44, Heiko Stübner wrote: Hi Roger, the comments inline are a rough first review. I hope to get a clearer picture for the stuff I'm not sure about in v3 once the big issues

Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Hi! Heiko about regulator, power gpio, reset gpio and irq gpio please refer to my comment inline, tks. On 2014/12/2 7:44, Heiko Stübner wrote: Hi Roger, the comments inline are a rough first review. I hope to get a clearer picture for the stuff I'm not sure about in v3 once the big issues

Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Hi Roger, the comments inline are a rough first review. I hope to get a clearer picture for the stuff I'm not sure about in v3 once the big issues are fixed. Am Donnerstag, 27. November 2014, 10:52:08 schrieb Roger Chen: > This driver is based on stmmac driver. > > modification based on

Re: [PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

Hi Roger, the comments inline are a rough first review. I hope to get a clearer picture for the stuff I'm not sure about in v3 once the big issues are fixed. Am Donnerstag, 27. November 2014, 10:52:08 schrieb Roger Chen: This driver is based on stmmac driver. modification based on Giuseppe

[PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

This driver is based on stmmac driver. modification based on Giuseppe CAVALLARO's suggestion: 1. use BIT() > +/*RK3288_GRF_SOC_CON3*/ > +#define GMAC_TXCLK_DLY_ENABLE ((0x4000 << 16) | (0x4000)) > +#define GMAC_TXCLK_DLY_DISABLE ((0x4000 << 16) | (0x)) ...

[PATCH v2 1/6] GMAC: add driver for Rockchip RK3288 SoCs integrated GMAC

This driver is based on stmmac driver. modification based on Giuseppe CAVALLARO's suggestion: 1. use BIT() +/*RK3288_GRF_SOC_CON3*/ +#define GMAC_TXCLK_DLY_ENABLE ((0x4000 16) | (0x4000)) +#define GMAC_TXCLK_DLY_DISABLE ((0x4000 16) | (0x)) ...