Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Serge Semin
On Tue, Dec 05, 2017 at 01:27:57PM -0500, Jon Mason wrote: > On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > > DB interface of ntb_tool driver hasn't been changed much, but > > db_valid_mask DebugFS file has still been added to new ntb_tool > >

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Serge Semin
On Tue, Dec 05, 2017 at 01:27:57PM -0500, Jon Mason wrote: > On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > > DB interface of ntb_tool driver hasn't been changed much, but > > db_valid_mask DebugFS file has still been added to new ntb_tool > > driver. In this case it's much better to test

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 11:27 AM, Jon Mason wrote: echo "Running db tests on: $(basename $LOC) / $(basename $REM)" - write_file "c $DB_BITMASK" "$REM/db" + DB_VALID_MASK=$(read_file "$LOC/db_valid_mask") - for ((i=1; i <= 8; i++)); do - let DB=$(read_file

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 11:27 AM, Jon Mason wrote: echo "Running db tests on: $(basename $LOC) / $(basename $REM)" - write_file "c $DB_BITMASK" "$REM/db" + DB_VALID_MASK=$(read_file "$LOC/db_valid_mask") - for ((i=1; i <= 8; i++)); do - let DB=$(read_file

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > DB interface of ntb_tool driver hasn't been changed much, but > db_valid_mask DebugFS file has still been added to new ntb_tool > driver. In this case it's much better to test all valid DB bits > instead of using the

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-05 Thread Jon Mason
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > DB interface of ntb_tool driver hasn't been changed much, but > db_valid_mask DebugFS file has still been added to new ntb_tool > driver. In this case it's much better to test all valid DB bits > instead of using the predefined mask, which may

[PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-03 Thread Serge Semin
DB interface of ntb_tool driver hasn't been changed much, but db_valid_mask DebugFS file has still been added to new ntb_tool driver. In this case it's much better to test all valid DB bits instead of using the predefined mask, which may be incorrect in general. Signed-off-by: Serge Semin

[PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

2017-12-03 Thread Serge Semin
DB interface of ntb_tool driver hasn't been changed much, but db_valid_mask DebugFS file has still been added to new ntb_tool driver. In this case it's much better to test all valid DB bits instead of using the predefined mask, which may be incorrect in general. Signed-off-by: Serge Semin ---