Re: [PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

Hi Andy, On 日, 6月 25, 2017 at 06:06:44下午 +0300, Andy Shevchenko wrote: > On Wed, Jun 21, 2017 at 10:23 AM, Baolin Wang > wrote: > > This patch adds the I2C controller driver for Spreadtrum platform. > > Needs more work. > See my comments below. > > > > >

Re: [PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

Hi Andy, On 日, 6月 25, 2017 at 06:06:44下午 +0300, Andy Shevchenko wrote: > On Wed, Jun 21, 2017 at 10:23 AM, Baolin Wang > wrote: > > This patch adds the I2C controller driver for Spreadtrum platform. > > Needs more work. > See my comments below. > > > > > +#include > > > +#include > >

Re: [PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

On Wed, Jun 21, 2017 at 10:23 AM, Baolin Wang wrote: > This patch adds the I2C controller driver for Spreadtrum platform. Needs more work. See my comments below. > +#include > +#include Since your answer to the comment about arch_initcall you perhaps need to

Re: [PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

On Wed, Jun 21, 2017 at 10:23 AM, Baolin Wang wrote: > This patch adds the I2C controller driver for Spreadtrum platform. Needs more work. See my comments below. > +#include > +#include Since your answer to the comment about arch_initcall you perhaps need to get rid of tristate (use bool)

Re: [PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

Hi Baolin, [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.12-rc6 next-20170623] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

Hi Baolin, [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.12-rc6 next-20170623] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

This patch adds the I2C controller driver for Spreadtrum platform. Signed-off-by: Baolin Wang --- Changes since v1: - Power on I2C device in probe(). - Remove redundant macros and usb __maybe_unused. - Remove redundant 'of_match_ptr'. - Modify return values and

[PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

This patch adds the I2C controller driver for Spreadtrum platform. Signed-off-by: Baolin Wang --- Changes since v1: - Power on I2C device in probe(). - Remove redundant macros and usb __maybe_unused. - Remove redundant 'of_match_ptr'. - Modify return values and check the return value for