Re: [PATCH v2 2/2] staging: skein: Add Loadable Module Support

2014-10-23 Thread Dan Carpenter
On Wed, Oct 22, 2014 at 09:24:37PM -0500, Eric Rost wrote: > +static int __init skein_generic_mod_init(void) > +{ > + return crypto_register_shash() || crypto_register_shash() > + || crypto_register_shash(); Shouldn't it unwind on error? > +} regards, dan carpenter -- To

Re: [PATCH v2 2/2] staging: skein: Add Loadable Module Support

2014-10-23 Thread Dan Carpenter
On Wed, Oct 22, 2014 at 09:24:37PM -0500, Eric Rost wrote: +static int __init skein_generic_mod_init(void) +{ + return crypto_register_shash(alg256) || crypto_register_shash(alg512) + || crypto_register_shash(alg1024); Shouldn't it unwind on error? +} regards, dan carpenter

[PATCH v2 2/2] staging: skein: Add Loadable Module Support

2014-10-22 Thread Eric Rost
Adds loadable module support for skein_mod, containing skein256, skein512, and skein1024 algorithms. Signed-off-by: Eric Rost --- drivers/staging/skein/Kconfig | 2 +- drivers/staging/skein/skein_generic.c | 122 ++ 2 files changed, 123 insertions(+), 1

[PATCH v2 2/2] staging: skein: Add Loadable Module Support

2014-10-22 Thread Eric Rost
Adds loadable module support for skein_mod, containing skein256, skein512, and skein1024 algorithms. Signed-off-by: Eric Rost eric.r...@mybabylon.net --- drivers/staging/skein/Kconfig | 2 +- drivers/staging/skein/skein_generic.c | 122 ++ 2 files