RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-12 Thread B, Ravi
JAY; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Balbi, Felipe Subject: RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform >>>> + >>>> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); >>>>

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-12 Thread B, Ravi
+ + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); + phy->phy_wkup = ioremap(res->start, resource_size(res)); >>> devm_ioremap? >> The phy_wakeup register is common across two instances of phy, >> devm_ioremap_resource() will fail to map for twice for

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-12 Thread B, Ravi
+ + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, phy_wkup); + phy-phy_wkup = ioremap(res-start, resource_size(res)); devm_ioremap? The phy_wakeup register is common across two instances of phy, devm_ioremap_resource() will fail to map for twice for same register space.

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-12 Thread B, Ravi
-...@vger.kernel.org; linux-kernel@vger.kernel.org; Balbi, Felipe Subject: RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, phy_wkup); + phy-phy_wkup = ioremap(res-start, resource_size(res)); devm_ioremap

Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread Sergei Shtylyov
Hello. On 06/11/2013 01:45 PM, B, Ravi wrote: + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); + phy->phy_wkup = ioremap(res->start, resource_size(res)); devm_ioremap? The phy_wakeup register is common across two instances of phy,

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread B, Ravi
Kishon > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Balbi, Felipe > Subject: Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx > platform >> + >> +res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); >

Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread Kishon Vijay Abraham I
Hi, On Tuesday 11 June 2013 12:47 PM, Ravi Babu wrote: Adds usb-phy driver support for am33xx platform, the host/device peripheral controller shall get this phy object to control the phy operations. Signed-off-by: Ravi Babu --- drivers/usb/phy/Kconfig|9 ++

[PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread Ravi Babu
Adds usb-phy driver support for am33xx platform, the host/device peripheral controller shall get this phy object to control the phy operations. Signed-off-by: Ravi Babu --- drivers/usb/phy/Kconfig|9 ++ drivers/usb/phy/Makefile |1 + drivers/usb/phy/phy-dsps-usb.c | 236

[PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread Ravi Babu
Adds usb-phy driver support for am33xx platform, the host/device peripheral controller shall get this phy object to control the phy operations. Signed-off-by: Ravi Babu ravib...@ti.com --- drivers/usb/phy/Kconfig|9 ++ drivers/usb/phy/Makefile |1 +

Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread Kishon Vijay Abraham I
Hi, On Tuesday 11 June 2013 12:47 PM, Ravi Babu wrote: Adds usb-phy driver support for am33xx platform, the host/device peripheral controller shall get this phy object to control the phy operations. Signed-off-by: Ravi Babu ravib...@ti.com --- drivers/usb/phy/Kconfig|9 ++

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread B, Ravi
Kishon Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Balbi, Felipe Subject: Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform + +res = platform_get_resource_byname(pdev, IORESOURCE_MEM, phy_wkup); +phy-phy_wkup = ioremap(res-start

Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread Sergei Shtylyov
Hello. On 06/11/2013 01:45 PM, B, Ravi wrote: + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, phy_wkup); + phy-phy_wkup = ioremap(res-start, resource_size(res)); devm_ioremap? The phy_wakeup register is common across two instances of phy, devm_ioremap_resource()