RE: [PATCH v2 2/9] fs: Introduce i_blocks_per_page

2020-09-15 Thread David Laight
From: Matthew Wilcox (Oracle) > Sent: 11 September 2020 00:47 > This helper is useful for both THPs and for supporting block size larger > than page size. Convert all users that I could find (we have a few > different ways of writing this idiom, and I may have missed some). > ... > diff --git

Re: [PATCH v2 2/9] fs: Introduce i_blocks_per_page

2020-09-15 Thread Matthew Wilcox
On Tue, Sep 15, 2020 at 03:40:52PM +, David Laight wrote: > > @@ -147,7 +147,7 @@ iomap_iop_set_range_uptodate(struct page *page, > > unsigned off, unsigned len) > > unsigned int i; > > > > spin_lock_irqsave(>uptodate_lock, flags); > > - for (i = 0; i < PAGE_SIZE /

Re: [PATCH v2 2/9] fs: Introduce i_blocks_per_page

2020-09-15 Thread Dave Kleikamp
On 9/10/20 6:47 PM, Matthew Wilcox (Oracle) wrote: > This helper is useful for both THPs and for supporting block size larger > than page size. Convert all users that I could find (we have a few > different ways of writing this idiom, and I may have missed some). > > Signed-off-by: Matthew

[PATCH v2 2/9] fs: Introduce i_blocks_per_page

2020-09-10 Thread Matthew Wilcox (Oracle)
This helper is useful for both THPs and for supporting block size larger than page size. Convert all users that I could find (we have a few different ways of writing this idiom, and I may have missed some). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Reviewed-by: Dave