Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-08-10 Thread Sean Wang
On Wed, 2017-08-09 at 17:22 +0800, Yingjoe Chen wrote: > On Tue, 2017-07-18 at 17:49 +0800, sean.w...@mediatek.com wrote: > > From: Chenglin Xu > > > > The MT6380 is a regulator found those boards with MediaTek MT7622 SoC > > It is connected as a slave to the SoC using

Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-08-10 Thread Sean Wang
On Wed, 2017-08-09 at 17:22 +0800, Yingjoe Chen wrote: > On Tue, 2017-07-18 at 17:49 +0800, sean.w...@mediatek.com wrote: > > From: Chenglin Xu > > > > The MT6380 is a regulator found those boards with MediaTek MT7622 SoC > > It is connected as a slave to the SoC using MediaTek PMIC wrapper

Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-08-10 Thread Sean Wang
On Tue, 2017-07-18 at 14:31 +0100, Mark Brown wrote: > On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.w...@mediatek.com wrote: > > > + if (!info->modeset_mask) { > > + dev_err(>dev, "regulator %s doesn't support set_mode\n", > > + info->desc.name); > > +

Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-08-10 Thread Sean Wang
On Tue, 2017-07-18 at 14:31 +0100, Mark Brown wrote: > On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.w...@mediatek.com wrote: > > > + if (!info->modeset_mask) { > > + dev_err(>dev, "regulator %s doesn't support set_mode\n", > > + info->desc.name); > > +

Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-08-09 Thread Yingjoe Chen
On Tue, 2017-07-18 at 17:49 +0800, sean.w...@mediatek.com wrote: > From: Chenglin Xu > > The MT6380 is a regulator found those boards with MediaTek MT7622 SoC > It is connected as a slave to the SoC using MediaTek PMIC wrapper which > is the common interface connecting

Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-08-09 Thread Yingjoe Chen
On Tue, 2017-07-18 at 17:49 +0800, sean.w...@mediatek.com wrote: > From: Chenglin Xu > > The MT6380 is a regulator found those boards with MediaTek MT7622 SoC > It is connected as a slave to the SoC using MediaTek PMIC wrapper which > is the common interface connecting with Mediatek made various

Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-07-18 Thread Mark Brown
On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.w...@mediatek.com wrote: > + if (!info->modeset_mask) { > + dev_err(>dev, "regulator %s doesn't support set_mode\n", > + info->desc.name); > + return -EINVAL; > + } This is mostly fine but the mode

Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-07-18 Thread Mark Brown
On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.w...@mediatek.com wrote: > + if (!info->modeset_mask) { > + dev_err(>dev, "regulator %s doesn't support set_mode\n", > + info->desc.name); > + return -EINVAL; > + } This is mostly fine but the mode

[PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-07-18 Thread sean.wang
From: Chenglin Xu The MT6380 is a regulator found those boards with MediaTek MT7622 SoC It is connected as a slave to the SoC using MediaTek PMIC wrapper which is the common interface connecting with Mediatek made various PMICs. Signed-off-by: Chenglin Xu

[PATCH v2 3/9] regulator: mt6380: Add support for MT6380

2017-07-18 Thread sean.wang
From: Chenglin Xu The MT6380 is a regulator found those boards with MediaTek MT7622 SoC It is connected as a slave to the SoC using MediaTek PMIC wrapper which is the common interface connecting with Mediatek made various PMICs. Signed-off-by: Chenglin Xu Signed-off-by: Sean Wang ---