Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: > On 31/03/17 15:00, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >> Your first implementation could be just that. Refactoring what needs to >> be refactored, then patching "mode" debugfs to work properly in that

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: > On 31/03/17 15:00, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >> Your first implementation could be just that. Refactoring what needs to >> be refactored, then patching "mode" debugfs to work properly in that >> case. Only add

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 31/03/17 15:00, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > Your first implementation could be just that. Refactoring what needs to > be refactored, then patching "mode" debugfs to work properly in that > case. Only add otg.c/drd.c after "mode"

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 31/03/17 15:00, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > Your first implementation could be just that. Refactoring what needs to > be refactored, then patching "mode" debugfs to work properly in that > case. Only add otg.c/drd.c after "mode" debugfs file is

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: Your first implementation could be just that. Refactoring what needs to be refactored, then patching "mode" debugfs to work properly in that case. Only add otg.c/drd.c after "mode" debugfs file is stable, because then you know what

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: Your first implementation could be just that. Refactoring what needs to be refactored, then patching "mode" debugfs to work properly in that case. Only add otg.c/drd.c after "mode" debugfs file is stable, because then you know what needs to be taken

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

+Mathias On 31/03/17 10:46, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > Roger Quadros writes: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role. > > yeah, that's not a

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

+Mathias On 31/03/17 10:46, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > Roger Quadros writes: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role. > > yeah, that's not a quirk. DRA7 supports OTGv2, not

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: Roger Quadros writes: > dra7 OTG core limits the host controller to USB2.0 (high-speed) mode > when we're operating in dual-role. yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no USB3 when

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: Roger Quadros writes: > dra7 OTG core limits the host controller to USB2.0 (high-speed) mode > when we're operating in dual-role. yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no USB3 when OTGv2 was written.

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, On 29/03/17 13:32, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. >>> >>> yeah, that's not a quirk. DRA7

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, On 29/03/17 13:32, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. >>> >>> yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 30/03/17 12:32, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: 3) All this becomes even more complex for configfs based gadget driver. So using stop/start gadget is a much simpler solution really as UDC software side of things remain unchanged

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 30/03/17 12:32, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: 3) All this becomes even more complex for configfs based gadget driver. So using stop/start gadget is a much simpler solution really as UDC software side of things remain unchanged and the gadget

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: >>> 3) All this becomes even more complex for configfs based gadget driver. >>> >>> So using stop/start gadget is a much simpler solution really as UDC software >>> side of things remain unchanged and the gadget driver can persist between >>> role

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: >>> 3) All this becomes even more complex for configfs based gadget driver. >>> >>> So using stop/start gadget is a much simpler solution really as UDC software >>> side of things remain unchanged and the gadget driver can persist between >>> role switches. >> >> I

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 29/03/17 16:21, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: > Roger Quadros writes: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role.

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 29/03/17 16:21, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: > Roger Quadros writes: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role. > > yeah, that's not a quirk. DRA7

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: >> Roger Quadros writes: Roger Quadros writes: > dra7 OTG core limits the host controller to USB2.0 (high-speed) mode > when we're operating in dual-role. yeah, that's not a quirk. DRA7 supports

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: >> Roger Quadros writes: Roger Quadros writes: > dra7 OTG core limits the host controller to USB2.0 (high-speed) mode > when we're operating in dual-role. yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no USB3 when

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 29/03/17 13:32, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. >>> >>> yeah, that's not a quirk. DRA7 supports

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 29/03/17 13:32, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. >>> >>> yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: >> Roger Quadros writes: >>> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >>> when we're operating in dual-role. >> >> yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no >> USB3 when OTGv2 was

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: >> Roger Quadros writes: >>> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >>> when we're operating in dual-role. >> >> yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no >> USB3 when OTGv2 was written. >> >> DRA7 just

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 28/03/17 14:10, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role. > > yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no > USB3 when OTGv2 was

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 28/03/17 14:10, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role. > > yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no > USB3 when OTGv2 was written. > >

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: > dra7 OTG core limits the host controller to USB2.0 (high-speed) mode > when we're operating in dual-role. yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no USB3 when OTGv2 was written. DRA7 just shouldn't use OTG core altogether.

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, Roger Quadros writes: > dra7 OTG core limits the host controller to USB2.0 (high-speed) mode > when we're operating in dual-role. yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no USB3 when OTGv2 was written. DRA7 just shouldn't use OTG core altogether. In fact, this

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 25/02/17 05:35, Chanwoo Choi wrote: > Hi Roger, > > [snip] > >> /* dwc->lock must be held */ >> static void dwc3_otg_core_exit(struct dwc3 *dwc) >> { >> + if (dwc->edev) >> + return; >> + >> /* disable all otg irqs */ >> dwc3_otg_disable_events(dwc,

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 25/02/17 05:35, Chanwoo Choi wrote: > Hi Roger, > > [snip] > >> /* dwc->lock must be held */ >> static void dwc3_otg_core_exit(struct dwc3 *dwc) >> { >> + if (dwc->edev) >> + return; >> + >> /* disable all otg irqs */ >> dwc3_otg_disable_events(dwc,

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On Sat, Feb 25, 2017 at 9:20 AM, Chanwoo Choi wrote: > 2017-02-25 12:46 GMT+09:00 Chanwoo Choi : >> Hi, >> >> 2017-02-24 21:02 GMT+09:00 Roger Quadros : >>> +Chanwoo >>> >>> Hi Vivek, >>> >>> On 23/02/17 10:34, Vivek Gautam wrote:

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On Sat, Feb 25, 2017 at 9:20 AM, Chanwoo Choi wrote: > 2017-02-25 12:46 GMT+09:00 Chanwoo Choi : >> Hi, >> >> 2017-02-24 21:02 GMT+09:00 Roger Quadros : >>> +Chanwoo >>> >>> Hi Vivek, >>> >>> On 23/02/17 10:34, Vivek Gautam wrote: On 02/16/2017 06:36 PM, Roger Quadros wrote: >

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

2017-02-25 12:46 GMT+09:00 Chanwoo Choi : > Hi, > > 2017-02-24 21:02 GMT+09:00 Roger Quadros : >> +Chanwoo >> >> Hi Vivek, >> >> On 23/02/17 10:34, Vivek Gautam wrote: >>> >>> >>> On 02/16/2017 06:36 PM, Roger Quadros wrote: dra7 OTG core limits the host

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

2017-02-25 12:46 GMT+09:00 Chanwoo Choi : > Hi, > > 2017-02-24 21:02 GMT+09:00 Roger Quadros : >> +Chanwoo >> >> Hi Vivek, >> >> On 23/02/17 10:34, Vivek Gautam wrote: >>> >>> >>> On 02/16/2017 06:36 PM, Roger Quadros wrote: dra7 OTG core limits the host controller to USB2.0 (high-speed) mode

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, 2017-02-24 21:02 GMT+09:00 Roger Quadros : > +Chanwoo > > Hi Vivek, > > On 23/02/17 10:34, Vivek Gautam wrote: >> >> >> On 02/16/2017 06:36 PM, Roger Quadros wrote: >>> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >>> when we're operating in dual-role.

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi, 2017-02-24 21:02 GMT+09:00 Roger Quadros : > +Chanwoo > > Hi Vivek, > > On 23/02/17 10:34, Vivek Gautam wrote: >> >> >> On 02/16/2017 06:36 PM, Roger Quadros wrote: >>> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >>> when we're operating in dual-role. >>> >>> We work

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi Roger, [snip] > /* dwc->lock must be held */ > static void dwc3_otg_core_exit(struct dwc3 *dwc) > { > + if (dwc->edev) > + return; > + > /* disable all otg irqs */ > dwc3_otg_disable_events(dwc, DWC3_OTG_ALL_EVENTS); > /* clear all events */ > @@

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

Hi Roger, [snip] > /* dwc->lock must be held */ > static void dwc3_otg_core_exit(struct dwc3 *dwc) > { > + if (dwc->edev) > + return; > + > /* disable all otg irqs */ > dwc3_otg_disable_events(dwc, DWC3_OTG_ALL_EVENTS); > /* clear all events */ > @@

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

+Chanwoo Hi Vivek, On 23/02/17 10:34, Vivek Gautam wrote: > > > On 02/16/2017 06:36 PM, Roger Quadros wrote: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role. >> >> We work around that by bypassing the OTG core and reading the >>

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

+Chanwoo Hi Vivek, On 23/02/17 10:34, Vivek Gautam wrote: > > > On 02/16/2017 06:36 PM, Roger Quadros wrote: >> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode >> when we're operating in dual-role. >> >> We work around that by bypassing the OTG core and reading the >>

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 02/24/2017 06:27 AM, Peter Chen wrote: On Thu, Feb 23, 2017 at 02:04:50PM +0530, Vivek Gautam wrote: On 02/16/2017 06:36 PM, Roger Quadros wrote: dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. We work around that by bypassing the

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 02/24/2017 06:27 AM, Peter Chen wrote: On Thu, Feb 23, 2017 at 02:04:50PM +0530, Vivek Gautam wrote: On 02/16/2017 06:36 PM, Roger Quadros wrote: dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. We work around that by bypassing the

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On Thu, Feb 23, 2017 at 02:04:50PM +0530, Vivek Gautam wrote: > > > On 02/16/2017 06:36 PM, Roger Quadros wrote: > >dra7 OTG core limits the host controller to USB2.0 (high-speed) mode > >when we're operating in dual-role. > > > >We work around that by bypassing the OTG core and reading the >

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On Thu, Feb 23, 2017 at 02:04:50PM +0530, Vivek Gautam wrote: > > > On 02/16/2017 06:36 PM, Roger Quadros wrote: > >dra7 OTG core limits the host controller to USB2.0 (high-speed) mode > >when we're operating in dual-role. > > > >We work around that by bypassing the OTG core and reading the >

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 02/16/2017 06:36 PM, Roger Quadros wrote: dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. We work around that by bypassing the OTG core and reading the extcon framework directly for ID/VBUS events. Signed-off-by: Roger Quadros

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

On 02/16/2017 06:36 PM, Roger Quadros wrote: dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. We work around that by bypassing the OTG core and reading the extcon framework directly for ID/VBUS events. Signed-off-by: Roger Quadros ---

[PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. We work around that by bypassing the OTG core and reading the extcon framework directly for ID/VBUS events. Signed-off-by: Roger Quadros ---

[PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

dra7 OTG core limits the host controller to USB2.0 (high-speed) mode when we're operating in dual-role. We work around that by bypassing the OTG core and reading the extcon framework directly for ID/VBUS events. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/usb/dwc3.txt |