Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Thursday 10 December 2015 16:59:14 xuejiancheng wrote: > On 2015/12/10 16:04, Arnd Bergmann wrote: > > On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: > >>> > >>> This is not what I meant. You have to use "syscon" as the most generic > >>> "compatible" value here, but should add a

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/10 16:04, Arnd Bergmann wrote: > On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: >>> >>> This is not what I meant. You have to use "syscon" as the most generic >>> "compatible" value here, but should add a machine specific string >>> as a more specific one.

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: > > > > This is not what I meant. You have to use "syscon" as the most generic > > "compatible" value here, but should add a machine specific string > > as a more specific one. "hisilicon,sysctrl" is not appropriate because > > it does not

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Thursday 10 December 2015 16:59:14 xuejiancheng wrote: > On 2015/12/10 16:04, Arnd Bergmann wrote: > > On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: > >>> > >>> This is not what I meant. You have to use "syscon" as the most generic > >>> "compatible" value here, but should add a

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: > > > > This is not what I meant. You have to use "syscon" as the most generic > > "compatible" value here, but should add a machine specific string > > as a more specific one. "hisilicon,sysctrl" is not appropriate because > > it does not

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/10 16:04, Arnd Bergmann wrote: > On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: >>> >>> This is not what I meant. You have to use "syscon" as the most generic >>> "compatible" value here, but should add a machine specific string >>> as a more specific one.

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/9 23:31, Arnd Bergmann wrote: > On Tuesday 08 December 2015 11:54:51 xuejiancheng wrote: >> On 2015/12/7 14:37, xuejiancheng wrote: >>> >>> On 2015/12/4 18:49, Arnd Bergmann wrote: On Friday 04 December 2015 10:27:58 xuejiancheng wrote: >> Maybe split out the sysctrl

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Tuesday 08 December 2015 11:54:51 xuejiancheng wrote: > On 2015/12/7 14:37, xuejiancheng wrote: > > > > On 2015/12/4 18:49, Arnd Bergmann wrote: > >> On Friday 04 December 2015 10:27:58 xuejiancheng wrote: > > >> Maybe split out the sysctrl binding from > >>

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Tuesday 08 December 2015 11:54:51 xuejiancheng wrote: > On 2015/12/7 14:37, xuejiancheng wrote: > > > > On 2015/12/4 18:49, Arnd Bergmann wrote: > >> On Friday 04 December 2015 10:27:58 xuejiancheng wrote: > > >> Maybe split out the sysctrl binding from > >>

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/9 23:31, Arnd Bergmann wrote: > On Tuesday 08 December 2015 11:54:51 xuejiancheng wrote: >> On 2015/12/7 14:37, xuejiancheng wrote: >>> >>> On 2015/12/4 18:49, Arnd Bergmann wrote: On Friday 04 December 2015 10:27:58 xuejiancheng wrote: >> Maybe split out the sysctrl

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/7 14:37, xuejiancheng wrote: > > On 2015/12/4 18:49, Arnd Bergmann wrote: >> On Friday 04 December 2015 10:27:58 xuejiancheng wrote: > +sysctrl: system-controller@1202 { > +compatible = "hisilicon,sysctrl"; > +

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 12/07/2015 02:37 PM, xuejiancheng wrote: As this seems to be a standard part, we can also think about making a high-level driver for in in drivers/soc rather than relying on the syscon driver which we tend to use more for one-off devices with random register layouts. Sorry. I didn't

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 12/07/2015 02:37 PM, xuejiancheng wrote: As this seems to be a standard part, we can also think about making a high-level driver for in in drivers/soc rather than relying on the syscon driver which we tend to use more for one-off devices with random register layouts. Sorry. I didn't

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/7 14:37, xuejiancheng wrote: > > On 2015/12/4 18:49, Arnd Bergmann wrote: >> On Friday 04 December 2015 10:27:58 xuejiancheng wrote: > +sysctrl: system-controller@1202 { > +compatible = "hisilicon,sysctrl"; > +

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/4 18:49, Arnd Bergmann wrote: > On Friday 04 December 2015 10:27:58 xuejiancheng wrote: >>> +sysctrl: system-controller@1202 { +compatible = "hisilicon,sysctrl"; +reg = <0x1202 0x1000>; +

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On 2015/12/4 18:49, Arnd Bergmann wrote: > On Friday 04 December 2015 10:27:58 xuejiancheng wrote: >>> +sysctrl: system-controller@1202 { +compatible = "hisilicon,sysctrl"; +reg = <0x1202 0x1000>; +

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Friday 04 December 2015 10:27:58 xuejiancheng wrote: > > > >> +sysctrl: system-controller@1202 { > >> +compatible = "hisilicon,sysctrl"; > >> +reg = <0x1202 0x1000>; > >> +reboot-offset = <0x4>; > >> +

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Friday 04 December 2015 10:27:58 xuejiancheng wrote: > > > >> +sysctrl: system-controller@1202 { > >> +compatible = "hisilicon,sysctrl"; > >> +reg = <0x1202 0x1000>; > >> +reboot-offset = <0x4>; > >> +

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

Hi Arnd, Thank you very much for all your comments. On 2015/12/3 17:36, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:44:28 Jiancheng Xue wrote: > >> + >> +/dts-v1/; >> +#include "hi3519.dtsi" >> + >> +/ { >> +model = "HiSilicon HI3519 DEMO Board"; >> +compatible =

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Thursday 03 December 2015 10:44:28 Jiancheng Xue wrote: > + > +/dts-v1/; > +#include "hi3519.dtsi" > + > +/ { > + model = "HiSilicon HI3519 DEMO Board"; > + compatible = "hisilicon,hi3519"; > + > + chosen { > + bootargs = "mem=64M console=ttyAMA0,115200 early_printk \ >

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

On Thursday 03 December 2015 10:44:28 Jiancheng Xue wrote: > + > +/dts-v1/; > +#include "hi3519.dtsi" > + > +/ { > + model = "HiSilicon HI3519 DEMO Board"; > + compatible = "hisilicon,hi3519"; > + > + chosen { > + bootargs = "mem=64M console=ttyAMA0,115200 early_printk \ >

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

Hi Arnd, Thank you very much for all your comments. On 2015/12/3 17:36, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:44:28 Jiancheng Xue wrote: > >> + >> +/dts-v1/; >> +#include "hi3519.dtsi" >> + >> +/ { >> +model = "HiSilicon HI3519 DEMO Board"; >> +compatible =

[PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

add dts files for hi3519-demb board Signed-off-by: Jiancheng Xue --- arch/arm/boot/dts/Makefile| 2 + arch/arm/boot/dts/hi3519-demb.dts | 55 arch/arm/boot/dts/hi3519.dtsi | 129 ++ 3 files changed, 186 insertions(+) create

[PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

add dts files for hi3519-demb board Signed-off-by: Jiancheng Xue --- arch/arm/boot/dts/Makefile| 2 + arch/arm/boot/dts/hi3519-demb.dts | 55 arch/arm/boot/dts/hi3519.dtsi | 129 ++ 3 files changed, 186