Re: [PATCH v2 net] ethtool: netlink: add missing netdev_features_change() call

2020-11-09 Thread Jakub Kicinski
On Mon, 9 Nov 2020 15:00:02 +0100 Michal Kubecek wrote: > On Sun, Nov 08, 2020 at 12:46:15AM +, Alexander Lobakin wrote: > > After updating userspace Ethtool from 5.7 to 5.9, I noticed that > > NETDEV_FEAT_CHANGE is no more raised when changing netdev features > > through Ethtool. > > That's

Re: [PATCH v2 net] ethtool: netlink: add missing netdev_features_change() call

2020-11-09 Thread Michal Kubecek
On Sun, Nov 08, 2020 at 12:46:15AM +, Alexander Lobakin wrote: > After updating userspace Ethtool from 5.7 to 5.9, I noticed that > NETDEV_FEAT_CHANGE is no more raised when changing netdev features > through Ethtool. > That's because the old Ethtool ioctl interface always calls >

[PATCH v2 net] ethtool: netlink: add missing netdev_features_change() call

2020-11-07 Thread Alexander Lobakin
After updating userspace Ethtool from 5.7 to 5.9, I noticed that NETDEV_FEAT_CHANGE is no more raised when changing netdev features through Ethtool. That's because the old Ethtool ioctl interface always calls netdev_features_change() at the end of user request processing to inform the kernel that