Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Thu, May 10, 2018 at 03:27:24PM -0700, Kees Cook wrote: > On Fri, May 4, 2018 at 12:56 PM, Luis R. Rodriguez wrote: > > What a mighty short list of reviewers. Adding some more. My review below. > > I'd appreciate a Cc on future versions of these patches. > > Me too, please.

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Thu, May 10, 2018 at 03:27:24PM -0700, Kees Cook wrote: > On Fri, May 4, 2018 at 12:56 PM, Luis R. Rodriguez wrote: > > What a mighty short list of reviewers. Adding some more. My review below. > > I'd appreciate a Cc on future versions of these patches. > > Me too, please. And likely

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Fri, May 4, 2018 at 12:56 PM, Luis R. Rodriguez wrote: > What a mighty short list of reviewers. Adding some more. My review below. > I'd appreciate a Cc on future versions of these patches. Me too, please. And likely linux-security-module@ and Jessica too. > On Wed, May

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Fri, May 4, 2018 at 12:56 PM, Luis R. Rodriguez wrote: > What a mighty short list of reviewers. Adding some more. My review below. > I'd appreciate a Cc on future versions of these patches. Me too, please. And likely linux-security-module@ and Jessica too. > On Wed, May 02, 2018 at

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Mon, May 07, 2018 at 06:39:31PM +, Luis R. Rodriguez wrote: > > > Are you saying make 'static struct vfsmount *shm_mnt;' > > global and use it here? so no init_tmpfs() necessary? > > I think that can work, but feels that having two > > tmpfs mounts (one for shmem and one for umh) is

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Mon, May 07, 2018 at 06:39:31PM +, Luis R. Rodriguez wrote: > > > Are you saying make 'static struct vfsmount *shm_mnt;' > > global and use it here? so no init_tmpfs() necessary? > > I think that can work, but feels that having two > > tmpfs mounts (one for shmem and one for umh) is

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Fri, May 04, 2018 at 06:37:11PM -0700, Alexei Starovoitov wrote: > On Fri, May 04, 2018 at 07:56:43PM +, Luis R. Rodriguez wrote: > > What a mighty short list of reviewers. Adding some more. My review below. > > I'd appreciate a Cc on future versions of these patches. > > sure. > > > On

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Fri, May 04, 2018 at 06:37:11PM -0700, Alexei Starovoitov wrote: > On Fri, May 04, 2018 at 07:56:43PM +, Luis R. Rodriguez wrote: > > What a mighty short list of reviewers. Adding some more. My review below. > > I'd appreciate a Cc on future versions of these patches. > > sure. > > > On

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Sat, May 05, 2018 at 12:48:24AM -0400, Jann Horn wrote: > On Thu, May 3, 2018 at 12:36 AM, Alexei Starovoitov wrote: > > Introduce helper: > > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); > > struct umh_info { > >struct file *pipe_to_umh; > >

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Sat, May 05, 2018 at 12:48:24AM -0400, Jann Horn wrote: > On Thu, May 3, 2018 at 12:36 AM, Alexei Starovoitov wrote: > > Introduce helper: > > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); > > struct umh_info { > >struct file *pipe_to_umh; > >struct

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Thu, May 3, 2018 at 12:36 AM, Alexei Starovoitov wrote: > Introduce helper: > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); > struct umh_info { >struct file *pipe_to_umh; >struct file *pipe_from_umh; >pid_t pid; > }; > > that

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Thu, May 3, 2018 at 12:36 AM, Alexei Starovoitov wrote: > Introduce helper: > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); > struct umh_info { >struct file *pipe_to_umh; >struct file *pipe_from_umh; >pid_t pid; > }; > > that GPLed kernel

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Fri, May 04, 2018 at 07:56:43PM +, Luis R. Rodriguez wrote: > What a mighty short list of reviewers. Adding some more. My review below. > I'd appreciate a Cc on future versions of these patches. sure. > On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote: > > Introduce

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

On Fri, May 04, 2018 at 07:56:43PM +, Luis R. Rodriguez wrote: > What a mighty short list of reviewers. Adding some more. My review below. > I'd appreciate a Cc on future versions of these patches. sure. > On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote: > > Introduce

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

What a mighty short list of reviewers. Adding some more. My review below. I'd appreciate a Cc on future versions of these patches. On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote: > Introduce helper: > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); >

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

What a mighty short list of reviewers. Adding some more. My review below. I'd appreciate a Cc on future versions of these patches. On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote: > Introduce helper: > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); >

[PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

Introduce helper: int fork_usermode_blob(void *data, size_t len, struct umh_info *info); struct umh_info { struct file *pipe_to_umh; struct file *pipe_from_umh; pid_t pid; }; that GPLed kernel modules (signed or unsigned) can use it to execute part of its own data as

[PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

Introduce helper: int fork_usermode_blob(void *data, size_t len, struct umh_info *info); struct umh_info { struct file *pipe_to_umh; struct file *pipe_from_umh; pid_t pid; }; that GPLed kernel modules (signed or unsigned) can use it to execute part of its own data as