Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Sergei Shtylyov
On 03/20/2014 01:36 AM, Jason Gunthorpe wrote: The preferred multi-line comment style is: /* * bla * bla */ Sergei, the entire file use the 'net' multi-line commenting style, and I have maintined that consistency with the new code. No, you haven't followed the networking

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Jason Gunthorpe
On Thu, Mar 20, 2014 at 02:20:11AM +0300, Sergei Shtylyov wrote: > Hello. > > On 03/20/2014 01:14 AM, Jason Gunthorpe wrote: > > >>The preferred multi-line comment style is: > > >>/* > >> * bla > >> * bla > >> */ > > >Sergei, the entire file use the 'net' multi-line commenting style,

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Sergei Shtylyov
Hello. On 03/20/2014 01:14 AM, Jason Gunthorpe wrote: The preferred multi-line comment style is: /* * bla * bla */ Sergei, the entire file use the 'net' multi-line commenting style, and I have maintined that consistency with the new code. No, you haven't followed the

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Jason Gunthorpe
On Wed, Mar 12, 2014 at 04:35:54PM -0500, Rob Herring wrote: > > Florian, do you know what path to mainline a this patch should take? > > Via David's net tree. Thanks > > + cp = of_get_property(device, "compatible", ); > > + if (cp == NULL) > > + return -EINVAL; > > +

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Jason Gunthorpe
On Wed, Mar 12, 2014 at 04:35:54PM -0500, Rob Herring wrote: Florian, do you know what path to mainline a this patch should take? Via David's net tree. Thanks + cp = of_get_property(device, compatible, cplen); + if (cp == NULL) + return -EINVAL; +

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Sergei Shtylyov
Hello. On 03/20/2014 01:14 AM, Jason Gunthorpe wrote: The preferred multi-line comment style is: /* * bla * bla */ Sergei, the entire file use the 'net' multi-line commenting style, and I have maintined that consistency with the new code. No, you haven't followed the

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Jason Gunthorpe
On Thu, Mar 20, 2014 at 02:20:11AM +0300, Sergei Shtylyov wrote: Hello. On 03/20/2014 01:14 AM, Jason Gunthorpe wrote: The preferred multi-line comment style is: /* * bla * bla */ Sergei, the entire file use the 'net' multi-line commenting style, and I have maintined

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-19 Thread Sergei Shtylyov
On 03/20/2014 01:36 AM, Jason Gunthorpe wrote: The preferred multi-line comment style is: /* * bla * bla */ Sergei, the entire file use the 'net' multi-line commenting style, and I have maintined that consistency with the new code. No, you haven't followed the networking

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-12 Thread Florian Fainelli
2014-03-12 14:35 GMT-07:00 Rob Herring : > On Wed, Mar 12, 2014 at 4:05 PM, Jason Gunthorpe > wrote: >> This makes the generic of_mdiobus_register parse the DT compatible string for >> the pattern ethernet-phy-id.. If present it should be a value that >> matches the phy-id register

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-12 Thread Sergei Shtylyov
Hello. On 03/13/2014 12:05 AM, Jason Gunthorpe wrote: This makes the generic of_mdiobus_register parse the DT compatible string for the pattern ethernet-phy-id.. If present it should be a value that matches the phy-id register normally readable through MDIO. When the ID is given the

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-12 Thread Rob Herring
On Wed, Mar 12, 2014 at 4:05 PM, Jason Gunthorpe wrote: > This makes the generic of_mdiobus_register parse the DT compatible string for > the pattern ethernet-phy-id.. If present it should be a value that > matches the phy-id register normally readable through MDIO. > > When the ID is

[PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-12 Thread Jason Gunthorpe
This makes the generic of_mdiobus_register parse the DT compatible string for the pattern ethernet-phy-id.. If present it should be a value that matches the phy-id register normally readable through MDIO. When the ID is given the phy autoprobing is defeated and the phy is created

[PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-12 Thread Jason Gunthorpe
This makes the generic of_mdiobus_register parse the DT compatible string for the pattern ethernet-phy-id.. If present it should be a value that matches the phy-id register normally readable through MDIO. When the ID is given the phy autoprobing is defeated and the phy is created

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-12 Thread Rob Herring
On Wed, Mar 12, 2014 at 4:05 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: This makes the generic of_mdiobus_register parse the DT compatible string for the pattern ethernet-phy-id.. If present it should be a value that matches the phy-id register normally readable through

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-12 Thread Sergei Shtylyov
Hello. On 03/13/2014 12:05 AM, Jason Gunthorpe wrote: This makes the generic of_mdiobus_register parse the DT compatible string for the pattern ethernet-phy-id.. If present it should be a value that matches the phy-id register normally readable through MDIO. When the ID is given the

Re: [PATCH v2a RESEND 2/2] of_mdio: Allow the DT to specify the phy ID and avoid autoprobing

2014-03-12 Thread Florian Fainelli
2014-03-12 14:35 GMT-07:00 Rob Herring robherri...@gmail.com: On Wed, Mar 12, 2014 at 4:05 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: This makes the generic of_mdiobus_register parse the DT compatible string for the pattern ethernet-phy-id.. If present it should be a