Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

2021-04-09 Thread Gustavo A. R. Silva
Hi! On 4/9/21 01:54, Gustavo A. R. Silva wrote: > > Hi! > > I think I might have caught the issue: > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index e5e0713bebcd8..9231457371100 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1937,17 +1937,17 @@

Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

2021-04-09 Thread Gustavo A. R. Silva
Hi! I think I might have caught the issue: diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index e5e0713bebcd8..9231457371100 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1937,17 +1937,17 @@ xfs_init_zones(void) goto out_destroy_trans_zone;

Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

2021-03-20 Thread Darrick J. Wong
On Sat, Mar 20, 2021 at 03:20:55PM -0500, Gustavo A. R. Silva wrote: > > > On 3/20/21 15:17, Darrick J. Wong wrote: > Below are the results of running xfstests for groups shutdown and log > with the following configuration in local.config: > > export TEST_DEV=/dev/sda3 >

Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

2021-03-20 Thread Gustavo A. R. Silva
On 3/20/21 15:17, Darrick J. Wong wrote: Below are the results of running xfstests for groups shutdown and log with the following configuration in local.config: export TEST_DEV=/dev/sda3 export TEST_DIR=/mnt/test export SCRATCH_DEV=/dev/sda4 export

Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

2021-03-20 Thread Darrick J. Wong
On Mon, Mar 15, 2021 at 01:31:17PM -0500, Gustavo A. R. Silva wrote: > > > On 3/10/21 22:47, Darrick J. Wong wrote: > > On Wed, Mar 10, 2021 at 10:23:02PM -0600, Gustavo A. R. Silva wrote: > >> There is a regular need in the kernel to provide a way to declare having > >> a dynamically sized set

Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

2021-03-15 Thread Gustavo A. R. Silva
On 3/10/21 22:47, Darrick J. Wong wrote: > On Wed, Mar 10, 2021 at 10:23:02PM -0600, Gustavo A. R. Silva wrote: >> There is a regular need in the kernel to provide a way to declare having >> a dynamically sized set of trailing elements in a structure. Kernel code >> should always use “flexible

Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

2021-03-10 Thread Darrick J. Wong
On Wed, Mar 10, 2021 at 10:23:02PM -0600, Gustavo A. R. Silva wrote: > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older >

[PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

2021-03-10 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].