RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-23 Thread Bard Liao
: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell > XPS 9343 I2S mode > > > If HPO is already muted as what we expected, it means "HPO L" and "HPO R" > > work properly. And there is no reason we create an event to do the same > > thi

RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-23 Thread Bard Liao
: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell > XPS 9343 I2S mode > > > If HPO is already muted as what we expected, it means "HPO L" and "HPO R" > > work properly. And there is no reason we create an event to do the same > > thi

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-22 Thread Kai-Heng Feng
[snip] > Let me explain it in more detail. rt5670 need to set a serious of > registers to prevent the pop noise of powering up/down muting/ > unmuting headphone. That's what rt5670_hp_event() does. But, > what rt286_hp_power_event do is only mute/unmute headphone > which is done by "HPO L" and

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-22 Thread Kai-Heng Feng
[snip] > Let me explain it in more detail. rt5670 need to set a serious of > registers to prevent the pop noise of powering up/down muting/ > unmuting headphone. That's what rt5670_hp_event() does. But, > what rt286_hp_power_event do is only mute/unmute headphone > which is done by "HPO L" and

RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-22 Thread Bard Liao
: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell > XPS 9343 I2S mode > > >> What I really want to do is something rt5670's rt5670_hp_event(), > >> maybe autodisable is not enough sometimes? > > > > It is different. rt5670_hp_event() is doing dep

RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-22 Thread Bard Liao
: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell > XPS 9343 I2S mode > > >> What I really want to do is something rt5670's rt5670_hp_event(), > >> maybe autodisable is not enough sometimes? > > > > It is different. rt5670_hp_event() is doing dep

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Kai-Heng Feng
r Chiou; alsa-de...@alsa-project.org; >> linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell >> XPS 9343 I2S mode >> > >> >> I had the same thought originally, but printk under each case suggests

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Kai-Heng Feng
a-project.org; >> linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell >> XPS 9343 I2S mode >> > >> >> I had the same thought originally, but printk under each case suggests >> >> otherwise

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Kai-Heng Feng
..@gmail.com; Oder Chiou; >> alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell >> XPS 9343 I2S mode >> >> >> >> + switch (event) { >> >> + case SND_SOC_DA

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Kai-Heng Feng
; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell >> XPS 9343 I2S mode >> >> >> >> + switch (event) { >> >> + case SND_SOC_DAPM_PRE

RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Bard Liao
v3] ASoC: rt286: fix headphone click/crack noise on Dell > XPS 9343 I2S mode > > > >> I had the same thought originally, but printk under each case suggests > >> otherwise - _POST_PMU is triggered not right after _PRE_PMU but right > >> before _PRE_PMD.

RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Bard Liao
v3] ASoC: rt286: fix headphone click/crack noise on Dell > XPS 9343 I2S mode > > > >> I had the same thought originally, but printk under each case suggests > >> otherwise - _POST_PMU is triggered not right after _PRE_PMU but right > >> before _PRE_PMD.

RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Bard Liao
: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell > XPS 9343 I2S mode > >> > >> + switch (event) { > >> + case SND_SOC_DAPM_PRE_PMD: > >> + case SND_SOC_DAPM_POST_PMD: > >> + case SND_SOC_DAPM_POST_PMU: > >>

RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-21 Thread Bard Liao
: Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell > XPS 9343 I2S mode > >> > >> + switch (event) { > >> + case SND_SOC_DAPM_PRE_PMD: > >> + case SND_SOC_DAPM_POST_PMD: > >> + case SND_SOC_DAPM_POST_PMU: > >>

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Kai-Heng Feng
m; Bard Liao; Oder Chiou; >> alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Kai-Heng Feng >> Subject: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS >> 9343 I2S mode >> >> + switch (event) { >> + case SND_SOC_DAPM_PRE_PMD:

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Kai-Heng Feng
; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Kai-Heng Feng >> Subject: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS >> 9343 I2S mode >> >> + switch (event) { >> + case SND_SOC_DAPM_PRE_PMD: >&g

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Kai-Heng Feng
On Tue, Mar 21, 2017 at 1:26 AM, Mark Brown wrote: > On Tue, Mar 21, 2017 at 12:23:53AM +0800, Kai-Heng Feng wrote: >> On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown wrote: > >> > As it says there "...and inserted automatically following the three dash >> >

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Kai-Heng Feng
On Tue, Mar 21, 2017 at 1:26 AM, Mark Brown wrote: > On Tue, Mar 21, 2017 at 12:23:53AM +0800, Kai-Heng Feng wrote: >> On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown wrote: > >> > As it says there "...and inserted automatically following the three dash >> > line". > >> I saw iteration changelog in

RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Bard Liao
t; Subject: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS > 9343 I2S mode > > + switch (event) { > + case SND_SOC_DAPM_PRE_PMD: > + case SND_SOC_DAPM_POST_PMD: > + case SND_SOC_DAPM_POST_PMU: > + snd_soc_write(cod

RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Bard Liao
t; Subject: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS > 9343 I2S mode > > + switch (event) { > + case SND_SOC_DAPM_PRE_PMD: > + case SND_SOC_DAPM_POST_PMD: > + case SND_SOC_DAPM_POST_PMU: > + snd_soc_write(cod

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Mark Brown
On Tue, Mar 21, 2017 at 12:23:53AM +0800, Kai-Heng Feng wrote: > On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown wrote: > > As it says there "...and inserted automatically following the three dash > > line". > I saw iteration changelog in git log all over the place, maybe add a

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Mark Brown
On Tue, Mar 21, 2017 at 12:23:53AM +0800, Kai-Heng Feng wrote: > On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown wrote: > > As it says there "...and inserted automatically following the three dash > > line". > I saw iteration changelog in git log all over the place, maybe add a > rule section for

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Kai-Heng Feng
On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown wrote: > On Mon, Mar 20, 2017 at 03:46:13PM +, Kai-Heng Feng wrote: >> On Mon, Mar 20, 2017 at 11:08 PM Mark Brown wrote: > >> > As covered in SubmittingPatches this should come after the ---, it >> >

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Kai-Heng Feng
On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown wrote: > On Mon, Mar 20, 2017 at 03:46:13PM +, Kai-Heng Feng wrote: >> On Mon, Mar 20, 2017 at 11:08 PM Mark Brown wrote: > >> > As covered in SubmittingPatches this should come after the ---, it >> > doesn't need to end up in the changelogs. > >>

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Mark Brown
On Mon, Mar 20, 2017 at 03:46:13PM +, Kai-Heng Feng wrote: > On Mon, Mar 20, 2017 at 11:08 PM Mark Brown wrote: > > As covered in SubmittingPatches this should come after the ---, it > > doesn't need to end up in the changelogs. > Do you mean >

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Mark Brown
On Mon, Mar 20, 2017 at 03:46:13PM +, Kai-Heng Feng wrote: > On Mon, Mar 20, 2017 at 11:08 PM Mark Brown wrote: > > As covered in SubmittingPatches this should come after the ---, it > > doesn't need to end up in the changelogs. > Do you mean >

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Mark Brown
On Mon, Mar 20, 2017 at 11:58:31AM +0800, Kai-Heng Feng wrote: > v3: > Implicit conversion instead of tenary operator. > > v2: > Use 'HP Power' instead of individual power events. As covered in SubmittingPatches this should come after the ---, it doesn't need to end up in the changelogs. > +

Re: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-20 Thread Mark Brown
On Mon, Mar 20, 2017 at 11:58:31AM +0800, Kai-Heng Feng wrote: > v3: > Implicit conversion instead of tenary operator. > > v2: > Use 'HP Power' instead of individual power events. As covered in SubmittingPatches this should come after the ---, it doesn't need to end up in the changelogs. > +

[PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-19 Thread Kai-Heng Feng
HDA mode fixed the issue by these two commits: '9476d369d7b3 ALSA: hda - Mute headphone pin on suspend on XPS13 9333' '3e1b0c4a9d56 ALSA: hda - Fix click noise at start on Dell XPS13' Apply the same workarounds to rt286 can solve the issue. When jack is plugged, it rapidly generates I2C

[PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

2017-03-19 Thread Kai-Heng Feng
HDA mode fixed the issue by these two commits: '9476d369d7b3 ALSA: hda - Mute headphone pin on suspend on XPS13 9333' '3e1b0c4a9d56 ALSA: hda - Fix click noise at start on Dell XPS13' Apply the same workarounds to rt286 can solve the issue. When jack is plugged, it rapidly generates I2C