Re: [PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

2016-08-06 Thread SF Markus Elfring
> +@err depends on context || org || report@ > +statement S; > +expression e; > +position j0; How do you think about to omit the number from this variable name? > +@@ > + > + e = devm_ioremap_resource(...); > +* if (!e@j0) S Are there any more functions to consider for such a source code

Re: [PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

2016-08-06 Thread SF Markus Elfring
> +@err depends on context || org || report@ > +statement S; > +expression e; > +position j0; How do you think about to omit the number from this variable name? > +@@ > + > + e = devm_ioremap_resource(...); > +* if (!e@j0) S Are there any more functions to consider for such a source code

[PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

2016-08-06 Thread Amitoj Kaur Chawla
This script detects cases which have incorrect error handling for devm_ioremap_resource function, employing a NULL test instead of an IS_ERR() test. Acked-by: Julia Lawall Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Changed script to

[PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

2016-08-06 Thread Amitoj Kaur Chawla
This script detects cases which have incorrect error handling for devm_ioremap_resource function, employing a NULL test instead of an IS_ERR() test. Acked-by: Julia Lawall Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Changed script to correct error handling instead of just

Re: [PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

2016-08-06 Thread Julia Lawall
On Sat, 6 Aug 2016, SF Markus Elfring wrote: > > +@err depends on context || org || report@ > > +statement S; > > +expression e; > > +position j0; > > How do you think about to omit the number from this variable name? > > > > +@@ > > + > > + e = devm_ioremap_resource(...); > > +* if (!e@j0) S

Re: [PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

2016-08-06 Thread Julia Lawall
On Sat, 6 Aug 2016, SF Markus Elfring wrote: > > +@err depends on context || org || report@ > > +statement S; > > +expression e; > > +position j0; > > How do you think about to omit the number from this variable name? > > > > +@@ > > + > > + e = devm_ioremap_resource(...); > > +* if (!e@j0) S