Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Yinghai Lu
On Thu, Aug 6, 2015 at 5:32 PM, Guenter Roeck wrote: > Assuming case 1) includes case 3), root bridge does not support IO, > I have both case 1 and 2. > > Anyway, I think I am giving up. Sorry, I just fail to understand the > use case(s) you are trying to cover. > > Why don't you submit a patch,

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Guenter Roeck
On 08/06/2015 04:32 PM, Yinghai Lu wrote: On Thu, Aug 6, 2015 at 9:18 AM, Guenter Roeck wrote: On 08/06/2015 08:58 AM, Yinghai Lu wrote: Ok, I admit that I am lost. Earlier it seemed that you were concerned about this case, where no io window is available or a bus doesn't support io, but a

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Yinghai Lu
On Thu, Aug 6, 2015 at 9:18 AM, Guenter Roeck wrote: > On 08/06/2015 08:58 AM, Yinghai Lu wrote: > Ok, I admit that I am lost. Earlier it seemed that you were concerned about > this case, where no io window is available or a bus doesn't support io, > but a non-transparent child does. Now you

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Guenter Roeck
On 08/06/2015 08:58 AM, Yinghai Lu wrote: On Wed, Aug 5, 2015 at 9:50 PM, Guenter Roeck wrote: If I understand you correctly, we might need to change the code in pci_read_bridge_io() as follows. From if (!(child->bus_flags & PCI_BUS_FLAGS_SUPPORTS_IO)) return; to

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Yinghai Lu
On Wed, Aug 5, 2015 at 9:50 PM, Guenter Roeck wrote: > If I understand you correctly, we might need to change the code > in pci_read_bridge_io() as follows. > > From > > if (!(child->bus_flags & PCI_BUS_FLAGS_SUPPORTS_IO)) > return; > > to something like > > if

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Yinghai Lu
On Thu, Aug 6, 2015 at 9:18 AM, Guenter Roeck li...@roeck-us.net wrote: On 08/06/2015 08:58 AM, Yinghai Lu wrote: Ok, I admit that I am lost. Earlier it seemed that you were concerned about this case, where no io window is available or a bus doesn't support io, but a non-transparent child

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Guenter Roeck
On 08/06/2015 04:32 PM, Yinghai Lu wrote: On Thu, Aug 6, 2015 at 9:18 AM, Guenter Roeck li...@roeck-us.net wrote: On 08/06/2015 08:58 AM, Yinghai Lu wrote: Ok, I admit that I am lost. Earlier it seemed that you were concerned about this case, where no io window is available or a bus doesn't

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Yinghai Lu
On Thu, Aug 6, 2015 at 5:32 PM, Guenter Roeck li...@roeck-us.net wrote: Assuming case 1) includes case 3), root bridge does not support IO, I have both case 1 and 2. Anyway, I think I am giving up. Sorry, I just fail to understand the use case(s) you are trying to cover. Why don't you

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Guenter Roeck
On 08/06/2015 08:58 AM, Yinghai Lu wrote: On Wed, Aug 5, 2015 at 9:50 PM, Guenter Roeck li...@roeck-us.net wrote: If I understand you correctly, we might need to change the code in pci_read_bridge_io() as follows. From if (!(child-bus_flags PCI_BUS_FLAGS_SUPPORTS_IO))

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-06 Thread Yinghai Lu
On Wed, Aug 5, 2015 at 9:50 PM, Guenter Roeck li...@roeck-us.net wrote: If I understand you correctly, we might need to change the code in pci_read_bridge_io() as follows. From if (!(child-bus_flags PCI_BUS_FLAGS_SUPPORTS_IO)) return; to something like

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Guenter Roeck
On 08/05/2015 09:25 PM, Yinghai Lu wrote: On Wed, Aug 5, 2015 at 7:22 PM, Guenter Roeck wrote: On 08/05/2015 06:38 PM, Yinghai Lu wrote: On Wed, Aug 5, 2015 at 6:14 PM, Yinghai Lu wrote: It only can avoid warning with bridge, and still have warning on devices under the bridge. also

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Yinghai Lu
On Wed, Aug 5, 2015 at 7:22 PM, Guenter Roeck wrote: > On 08/05/2015 06:38 PM, Yinghai Lu wrote: >> >> On Wed, Aug 5, 2015 at 6:14 PM, Yinghai Lu wrote: >>> >>> >>> It only can avoid warning with bridge, and still have warning on >>> devices under the bridge. >>> >>> also would have problem on

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Guenter Roeck
On 08/05/2015 06:38 PM, Yinghai Lu wrote: On Wed, Aug 5, 2015 at 6:14 PM, Yinghai Lu wrote: It only can avoid warning with bridge, and still have warning on devices under the bridge. also would have problem on transparent bridges, like BRIDGE_A BRIDGE_AADEVICE_AA

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Guenter Roeck
On 08/05/2015 06:14 PM, Yinghai Lu wrote: On Thu, Jul 30, 2015 at 7:15 PM, Guenter Roeck wrote: The PCI subsystem always assumes that I/O is supported on PCIe bridges and tries to assign an I/O window to each child bus even if that is not the case. This may result in messages such as:

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Yinghai Lu
On Wed, Aug 5, 2015 at 6:14 PM, Yinghai Lu wrote: > > It only can avoid warning with bridge, and still have warning on > devices under the bridge. > > also would have problem on transparent bridges, like > > BRIDGE_A BRIDGE_AADEVICE_AA >| >\--

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Yinghai Lu
On Thu, Jul 30, 2015 at 7:15 PM, Guenter Roeck wrote: > The PCI subsystem always assumes that I/O is supported on PCIe bridges > and tries to assign an I/O window to each child bus even if that is not > the case. > > This may result in messages such as: > > pcieport :02:00.0: res[7]=[io

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Yinghai Lu
On Wed, Aug 5, 2015 at 6:14 PM, Yinghai Lu ying...@kernel.org wrote: It only can avoid warning with bridge, and still have warning on devices under the bridge. also would have problem on transparent bridges, like BRIDGE_A BRIDGE_AADEVICE_AA |

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Guenter Roeck
On 08/05/2015 06:38 PM, Yinghai Lu wrote: On Wed, Aug 5, 2015 at 6:14 PM, Yinghai Lu ying...@kernel.org wrote: It only can avoid warning with bridge, and still have warning on devices under the bridge. also would have problem on transparent bridges, like BRIDGE_A BRIDGE_AADEVICE_AA

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Yinghai Lu
On Wed, Aug 5, 2015 at 7:22 PM, Guenter Roeck li...@roeck-us.net wrote: On 08/05/2015 06:38 PM, Yinghai Lu wrote: On Wed, Aug 5, 2015 at 6:14 PM, Yinghai Lu ying...@kernel.org wrote: It only can avoid warning with bridge, and still have warning on devices under the bridge. also would have

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Guenter Roeck
On 08/05/2015 06:14 PM, Yinghai Lu wrote: On Thu, Jul 30, 2015 at 7:15 PM, Guenter Roeck li...@roeck-us.net wrote: The PCI subsystem always assumes that I/O is supported on PCIe bridges and tries to assign an I/O window to each child bus even if that is not the case. This may result in

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Guenter Roeck
On 08/05/2015 09:25 PM, Yinghai Lu wrote: On Wed, Aug 5, 2015 at 7:22 PM, Guenter Roeck li...@roeck-us.net wrote: On 08/05/2015 06:38 PM, Yinghai Lu wrote: On Wed, Aug 5, 2015 at 6:14 PM, Yinghai Lu ying...@kernel.org wrote: It only can avoid warning with bridge, and still have warning on

Re: [PATCH v3] PCI: Only enable IO window if supported

2015-08-05 Thread Yinghai Lu
On Thu, Jul 30, 2015 at 7:15 PM, Guenter Roeck li...@roeck-us.net wrote: The PCI subsystem always assumes that I/O is supported on PCIe bridges and tries to assign an I/O window to each child bus even if that is not the case. This may result in messages such as: pcieport :02:00.0:

[PATCH v3] PCI: Only enable IO window if supported

2015-07-30 Thread Guenter Roeck
The PCI subsystem always assumes that I/O is supported on PCIe bridges and tries to assign an I/O window to each child bus even if that is not the case. This may result in messages such as: pcieport :02:00.0: res[7]=[io 0x1000-0x0fff] get_res_add_size add_size 1000 pcieport

[PATCH v3] PCI: Only enable IO window if supported

2015-07-30 Thread Guenter Roeck
The PCI subsystem always assumes that I/O is supported on PCIe bridges and tries to assign an I/O window to each child bus even if that is not the case. This may result in messages such as: pcieport :02:00.0: res[7]=[io 0x1000-0x0fff] get_res_add_size add_size 1000 pcieport