Re: [PATCH v3] mtd: remove DEBUGFS_RO_ATTR()

2018-12-02 Thread Frank Lee
On Sun, Dec 2, 2018 at 4:15 PM Boris Brezillon wrote: > > Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change > you do. I think you should change the subject line: > > "mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it" > > This way it covers all of your changes. > > On

Re: [PATCH v3] mtd: remove DEBUGFS_RO_ATTR()

2018-12-02 Thread Frank Lee
On Sun, Dec 2, 2018 at 4:15 PM Boris Brezillon wrote: > > Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change > you do. I think you should change the subject line: > > "mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it" > > This way it covers all of your changes. > > On

Re: [PATCH v3] mtd: remove DEBUGFS_RO_ATTR()

2018-12-02 Thread Boris Brezillon
Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change you do. I think you should change the subject line: "mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it" This way it covers all of your changes. On Sun, 2 Dec 2018 02:32:02 -0500 Yangtao Li wrote: > We already have

Re: [PATCH v3] mtd: remove DEBUGFS_RO_ATTR()

2018-12-02 Thread Boris Brezillon
Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change you do. I think you should change the subject line: "mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it" This way it covers all of your changes. On Sun, 2 Dec 2018 02:32:02 -0500 Yangtao Li wrote: > We already have

[PATCH v3] mtd: remove DEBUGFS_RO_ATTR()

2018-12-01 Thread Yangtao Li
We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define such a macro,so remove DEBUGFS_RO_ATTR.Also use DEFINE_SHOW_ATTRIBUTE to simplify some code. Signed-off-by: Yangtao Li --- changes in v3: -remove the blank line between the function definition and DEFINE_SHOW_ATTRIBUTE() ---

[PATCH v3] mtd: remove DEBUGFS_RO_ATTR()

2018-12-01 Thread Yangtao Li
We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define such a macro,so remove DEBUGFS_RO_ATTR.Also use DEFINE_SHOW_ATTRIBUTE to simplify some code. Signed-off-by: Yangtao Li --- changes in v3: -remove the blank line between the function definition and DEFINE_SHOW_ATTRIBUTE() ---