Re: [PATCH v3] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-07 Thread Baoquan He
On 05/04/17 at 09:25am, Thomas Garnier wrote: > > I think this needs a "Fixes:" tag and Cc: . Sorry for late response, should I resend with them? > > Agreed. > > > > > Other than that: > > > > Reviewed-by: Dan Williams > > Thanks again! > >

Re: [PATCH v3] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-07 Thread Baoquan He
On 05/04/17 at 09:25am, Thomas Garnier wrote: > > I think this needs a "Fixes:" tag and Cc: . Sorry for late response, should I resend with them? > > Agreed. > > > > > Other than that: > > > > Reviewed-by: Dan Williams > > Thanks again! > > Reviewed-by: Thomas Garnier > -- > Thomas

Re: [PATCH v3] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-04 Thread Thomas Garnier
On Wed, May 3, 2017 at 7:35 PM, Dan Williams wrote: > On Wed, May 3, 2017 at 7:25 PM, Baoquan He wrote: >> Jeff Moyer reported that on his system with two memory regions 0~64G and >> 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling

Re: [PATCH v3] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-04 Thread Thomas Garnier
On Wed, May 3, 2017 at 7:35 PM, Dan Williams wrote: > On Wed, May 3, 2017 at 7:25 PM, Baoquan He wrote: >> Jeff Moyer reported that on his system with two memory regions 0~64G and >> 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr >> will make system hang intermittently

Re: [PATCH v3] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-03 Thread Dan Williams
On Wed, May 3, 2017 at 7:25 PM, Baoquan He wrote: > Jeff Moyer reported that on his system with two memory regions 0~64G and > 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr > will make system hang intermittently during boot. While adding 'nokaslr' >

Re: [PATCH v3] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-03 Thread Dan Williams
On Wed, May 3, 2017 at 7:25 PM, Baoquan He wrote: > Jeff Moyer reported that on his system with two memory regions 0~64G and > 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr > will make system hang intermittently during boot. While adding 'nokaslr' > won't. > > This is

[PATCH v3] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-03 Thread Baoquan He
Jeff Moyer reported that on his system with two memory regions 0~64G and 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr will make system hang intermittently during boot. While adding 'nokaslr' won't. This is because the for loop count calculation in sync_global_pgds is

[PATCH v3] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-03 Thread Baoquan He
Jeff Moyer reported that on his system with two memory regions 0~64G and 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr will make system hang intermittently during boot. While adding 'nokaslr' won't. This is because the for loop count calculation in sync_global_pgds is