Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-27 Thread Luis R. Rodriguez
On Tue, Jun 27, 2017 at 05:26:05PM +0200, Jessica Yu wrote: > +++ Luis R. Rodriguez [27/06/17 00:44 +0200]: > > Feel free to decouple it, but note that then the commit log must then be > > changed. My own take is this fix is not so critical as it is a corner case, > > so > > I have instead

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-27 Thread Luis R. Rodriguez
On Tue, Jun 27, 2017 at 05:26:05PM +0200, Jessica Yu wrote: > +++ Luis R. Rodriguez [27/06/17 00:44 +0200]: > > Feel free to decouple it, but note that then the commit log must then be > > changed. My own take is this fix is not so critical as it is a corner case, > > so > > I have instead

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-27 Thread Jessica Yu
+++ Luis R. Rodriguez [27/06/17 00:44 +0200]: On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: +++ Kees Cook [20/06/17 17:23 -0700]: > On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez wrote: > > On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote:

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-27 Thread Jessica Yu
+++ Luis R. Rodriguez [27/06/17 00:44 +0200]: On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: +++ Kees Cook [20/06/17 17:23 -0700]: > On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez wrote: > > On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: > > > This v3 nukes

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-27 Thread Jessica Yu
+++ Petr Mladek [27/06/17 10:13 +0200]: On Tue 2017-06-27 02:27:44, Luis R. Rodriguez wrote: On Tue, Jun 27, 2017 at 12:44:42AM +0200, Luis R. Rodriguez wrote: > On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: > > +++ Kees Cook [20/06/17 17:23 -0700]: > > > On Tue, Jun 20, 2017 at

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-27 Thread Jessica Yu
+++ Petr Mladek [27/06/17 10:13 +0200]: On Tue 2017-06-27 02:27:44, Luis R. Rodriguez wrote: On Tue, Jun 27, 2017 at 12:44:42AM +0200, Luis R. Rodriguez wrote: > On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: > > +++ Kees Cook [20/06/17 17:23 -0700]: > > > On Tue, Jun 20, 2017 at

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-27 Thread Petr Mladek
On Tue 2017-06-27 02:27:44, Luis R. Rodriguez wrote: > On Tue, Jun 27, 2017 at 12:44:42AM +0200, Luis R. Rodriguez wrote: > > On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: > > > +++ Kees Cook [20/06/17 17:23 -0700]: > > > > On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-27 Thread Petr Mladek
On Tue 2017-06-27 02:27:44, Luis R. Rodriguez wrote: > On Tue, Jun 27, 2017 at 12:44:42AM +0200, Luis R. Rodriguez wrote: > > On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: > > > +++ Kees Cook [20/06/17 17:23 -0700]: > > > > On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez > > > >

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-26 Thread Luis R. Rodriguez
On Tue, Jun 27, 2017 at 12:44:42AM +0200, Luis R. Rodriguez wrote: > On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: > > +++ Kees Cook [20/06/17 17:23 -0700]: > > > On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez > > > wrote: > > > > On Fri, May 26, 2017 at

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-26 Thread Luis R. Rodriguez
On Tue, Jun 27, 2017 at 12:44:42AM +0200, Luis R. Rodriguez wrote: > On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: > > +++ Kees Cook [20/06/17 17:23 -0700]: > > > On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez > > > wrote: > > > > On Fri, May 26, 2017 at 02:12:24PM -0700, Luis

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-26 Thread Luis R. Rodriguez
On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: > +++ Kees Cook [20/06/17 17:23 -0700]: > > On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez > > wrote: > > > On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: > > > > This v3 nukes the proc sysctl

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-26 Thread Luis R. Rodriguez
On Mon, Jun 26, 2017 at 11:37:36PM +0200, Jessica Yu wrote: > +++ Kees Cook [20/06/17 17:23 -0700]: > > On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez > > wrote: > > > On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: > > > > This v3 nukes the proc sysctl interface in favor

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-26 Thread Jessica Yu
+++ Kees Cook [20/06/17 17:23 -0700]: On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez wrote: On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: This v3 nukes the proc sysctl interface in favor for just letting userspace just check kernel revision. Prior

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-26 Thread Jessica Yu
+++ Kees Cook [20/06/17 17:23 -0700]: On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez wrote: On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: This v3 nukes the proc sysctl interface in favor for just letting userspace just check kernel revision. Prior to whenever this is

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-20 Thread Kees Cook
On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez wrote: > On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: >> This v3 nukes the proc sysctl interface in favor for just letting userspace >> just check kernel revision. Prior to whenever this is merged

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-20 Thread Kees Cook
On Tue, Jun 20, 2017 at 1:56 PM, Luis R. Rodriguez wrote: > On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: >> This v3 nukes the proc sysctl interface in favor for just letting userspace >> just check kernel revision. Prior to whenever this is merged userspace should >> try to

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-20 Thread Luis R. Rodriguez
On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: > This v3 nukes the proc sysctl interface in favor for just letting userspace > just check kernel revision. Prior to whenever this is merged userspace should > try to avoid hammering more than 50 kmod threads as they can fail and

Re: [PATCH v3 0/4] kmod: help make deterministic

2017-06-20 Thread Luis R. Rodriguez
On Fri, May 26, 2017 at 02:12:24PM -0700, Luis R. Rodriguez wrote: > This v3 nukes the proc sysctl interface in favor for just letting userspace > just check kernel revision. Prior to whenever this is merged userspace should > try to avoid hammering more than 50 kmod threads as they can fail and

[PATCH v3 0/4] kmod: help make deterministic

2017-05-26 Thread Luis R. Rodriguez
This v3 nukes the proc sysctl interface in favor for just letting userspace just check kernel revision. Prior to whenever this is merged userspace should try to avoid hammering more than 50 kmod threads as they can fail and it'd get -ENOMEM. We do away with the old heuristics on assuming you

[PATCH v3 0/4] kmod: help make deterministic

2017-05-26 Thread Luis R. Rodriguez
This v3 nukes the proc sysctl interface in favor for just letting userspace just check kernel revision. Prior to whenever this is merged userspace should try to avoid hammering more than 50 kmod threads as they can fail and it'd get -ENOMEM. We do away with the old heuristics on assuming you