Re: [PATCH v3 02/12] buildid: Stash away kernels build ID on init

2021-04-08 Thread Stephen Boyd
Quoting Jessica Yu (2021-04-08 05:05:33) > +++ Stephen Boyd [30/03/21 20:05 -0700]: > >+/** > >+ * init_vmlinux_build_id - Get the running kernel's build ID > >+ * > >+ * Return: Running kernel's build ID > >+ */ > > Hm, init_vmlinux_build_id() doesn't return anything, so this comment is > not

Re: [PATCH v3 02/12] buildid: Stash away kernels build ID on init

2021-04-08 Thread Jessica Yu
+++ Stephen Boyd [30/03/21 20:05 -0700]: [snipped] diff --git a/lib/buildid.c b/lib/buildid.c index 010ab0674cb9..b939bbc59233 100644 --- a/lib/buildid.c +++ b/lib/buildid.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include #include #include @@ -171,3 +172,19

[PATCH v3 02/12] buildid: Stash away kernels build ID on init

2021-03-30 Thread Stephen Boyd
Parse the kernel's build ID at initialization so that other code can print a hex format string representation of the running kernel's build ID. This will be used in the kdump and dump_stack code so that developers can easily locate the vmlinux debug symbols for a crash/stacktrace. Cc: Jiri Olsa