Re: [PATCH v3 08/10] usb: phy: tegra: Add error handling & clean up.

2013-05-10 Thread Sergei Shtylyov
Hello. On 05/10/2013 05:54 PM, Venu Byravarasu wrote: Check return values from all GPIO APIs and handle errors accordingly. Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it. Signed-off-by:

[PATCH v3 08/10] usb: phy: tegra: Add error handling & clean up.

2013-05-10 Thread Venu Byravarasu
Check return values from all GPIO APIs and handle errors accordingly. Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it. Signed-off-by: Venu Byravarasu --- delta from v1: no changes. delta from

[PATCH v3 08/10] usb: phy: tegra: Add error handling clean up.

2013-05-10 Thread Venu Byravarasu
Check return values from all GPIO APIs and handle errors accordingly. Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- delta from v1: no

Re: [PATCH v3 08/10] usb: phy: tegra: Add error handling clean up.

2013-05-10 Thread Sergei Shtylyov
Hello. On 05/10/2013 05:54 PM, Venu Byravarasu wrote: Check return values from all GPIO APIs and handle errors accordingly. Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it. Signed-off-by: