On Thursday 14 February 2013 14:35:58 Benson Leung wrote:
> + asm volatile ("mov %%ebx, %%edi;" /* save ebx (for PIC) */
> + "cpuid;"
> + "mov %%ebx, %%esi;" /* pass to caller */
> + "mov %%edi, %%ebx;" /* restore ebx */
> +
Hi Benson,
checkpatch.pl doesn't love this syntax:
ERROR: spaces required around that ':' (ctx:ExV)
#113: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:142:
+ :"+a" (_eax), "=S" (_ebx), "=c" (_ecx), "=d" (_edx)
^
ERROR: spaces
Hi Benson,
checkpatch.pl doesn't love this syntax:
ERROR: spaces required around that ':' (ctx:ExV)
#113: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:142:
+ :+a (_eax), =S (_ebx), =c (_ecx), =d (_edx)
^
ERROR: spaces required
On Thursday 14 February 2013 14:35:58 Benson Leung wrote:
+ asm volatile (mov %%ebx, %%edi; /* save ebx (for PIC) */
+ cpuid;
+ mov %%ebx, %%esi; /* pass to caller */
+ mov %%edi, %%ebx; /* restore ebx */
+ :+a
x86_energy_perf_policy reads cpuid using the cpuid instruction.
On i686, when building with PIC, this clobbers ebx, the PIC register.
Fixed using the same cpuid accessor function that vap...@gentoo.org
created for i7z:
http://code.google.com/p/i7z/issues/detail?id=31
Signed-off-by: Benson Leung
Hi Len,
Please take a look at this patch to the x86_energy_perf_policy that allows
the tool to work when built for i686 with PIC enabled.
Thanks,
Benson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
Hi Len,
Please take a look at this patch to the x86_energy_perf_policy that allows
the tool to work when built for i686 with PIC enabled.
Thanks,
Benson
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
x86_energy_perf_policy reads cpuid using the cpuid instruction.
On i686, when building with PIC, this clobbers ebx, the PIC register.
Fixed using the same cpuid accessor function that vap...@gentoo.org
created for i7z:
http://code.google.com/p/i7z/issues/detail?id=31
Signed-off-by: Benson Leung
8 matches
Mail list logo