Re: [PATCH v3 1/2] staging: skein: Adds CryptoAPI Support

First of all this patch does too many things at once. Collapsing files and deleting them needs to be done in separate patches from adding them. There is the "one thing per patch" and each one of those is a separate thing. On Thu, Oct 23, 2014 at 05:12:10PM -0500, Eric Rost wrote: > +int

[PATCH v3 1/2] staging: skein: Adds CryptoAPI Support

Adds CryptoAPI support for skein256, skein512, and skein1024 algorithms. Also collapses threefish algorithm into skein.o and removes Kconfig option for Threefish. Signed-off-by: Eric Rost --- drivers/staging/skein/Kconfig | 22 +- drivers/staging/skein/Makefile| 13 +-

[PATCH v3 1/2] staging: skein: Adds CryptoAPI Support

Adds CryptoAPI support for skein256, skein512, and skein1024 algorithms. Also collapses threefish algorithm into skein.o and removes Kconfig option for Threefish. Signed-off-by: Eric Rost eric.r...@mybabylon.net --- drivers/staging/skein/Kconfig | 22 +- drivers/staging/skein/Makefile

Re: [PATCH v3 1/2] staging: skein: Adds CryptoAPI Support

First of all this patch does too many things at once. Collapsing files and deleting them needs to be done in separate patches from adding them. There is the one thing per patch and each one of those is a separate thing. On Thu, Oct 23, 2014 at 05:12:10PM -0500, Eric Rost wrote: +int