Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-25 Thread Joey Pabalinas
On Wed, Apr 25, 2018 at 08:09:31AM +0200, Greg Kroah-Hartman wrote: > Ah, never seen that before. Just use the defaults and you should be > fine. Having the normal diffstat is good. Yes, will definitely do from now on. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-25 Thread Joey Pabalinas
On Wed, Apr 25, 2018 at 08:09:31AM +0200, Greg Kroah-Hartman wrote: > Ah, never seen that before. Just use the defaults and you should be > fine. Having the normal diffstat is good. Yes, will definitely do from now on. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 24, 2018 at 07:45:30PM -1000, Joey Pabalinas wrote: > On Wed, Apr 25, 2018 at 07:38:48AM +0200, Greg Kroah-Hartman wrote: > > How are you sending these patches? How are you creating them? What is > > taking part of the diffstat off and just leaving that line? > > Hm, my `git

Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 24, 2018 at 07:45:30PM -1000, Joey Pabalinas wrote: > On Wed, Apr 25, 2018 at 07:38:48AM +0200, Greg Kroah-Hartman wrote: > > How are you sending these patches? How are you creating them? What is > > taking part of the diffstat off and just leaving that line? > > Hm, my `git

Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-24 Thread Joey Pabalinas
On Wed, Apr 25, 2018 at 07:38:48AM +0200, Greg Kroah-Hartman wrote: > How are you sending these patches? How are you creating them? What is > taking part of the diffstat off and just leaving that line? Hm, my `git format-patch` alias included --shortstat for some odd reason, very sorry about

Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-24 Thread Joey Pabalinas
On Wed, Apr 25, 2018 at 07:38:48AM +0200, Greg Kroah-Hartman wrote: > How are you sending these patches? How are you creating them? What is > taking part of the diffstat off and just leaving that line? Hm, my `git format-patch` alias included --shortstat for some odd reason, very sorry about

Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-24 Thread Greg Kroah-Hartman
On Tue, Apr 24, 2018 at 12:39:14PM -1000, Joey Pabalinas wrote: > Replace snprint() with strscpy() and use min_t() instead of > the conditional operator to clamp buffer length. > > Signed-off-by: Joey Pabalinas > > 1 file changed, 13 insertions(+), 13 deletions(-)

Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-24 Thread Greg Kroah-Hartman
On Tue, Apr 24, 2018 at 12:39:14PM -1000, Joey Pabalinas wrote: > Replace snprint() with strscpy() and use min_t() instead of > the conditional operator to clamp buffer length. > > Signed-off-by: Joey Pabalinas > > 1 file changed, 13 insertions(+), 13 deletions(-) Again, this is odd... How

[PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-24 Thread Joey Pabalinas
Replace snprint() with strscpy() and use min_t() instead of the conditional operator to clamp buffer length. Signed-off-by: Joey Pabalinas 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index

[PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

2018-04-24 Thread Joey Pabalinas
Replace snprint() with strscpy() and use min_t() instead of the conditional operator to clamp buffer length. Signed-off-by: Joey Pabalinas 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index b57b35066ebea94639..f26bf1d1e9ee0e74eb