Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Dmitry Vyukov
On Wed, Oct 1, 2014 at 6:11 PM, Andrey Ryabinin wrote: >>> >>> We can disable kasan instrumentation of this file as well. >> >> Yes, but why? I don't think we need that. > > Just gut feeling. Such tools usually don't play well together. For > example, due to asan

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Andrey Ryabinin
On 10/01/2014 05:27 PM, Dmitry Vyukov wrote: > On Wed, Oct 1, 2014 at 3:45 PM, Andrey Ryabinin > wrote: >> On 10/01/2014 02:39 PM, Catalin Marinas wrote: >>> On Mon, Sep 29, 2014 at 03:10:01PM +0100, Dmitry Vyukov wrote: On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin wrote: >

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Dmitry Vyukov
On Wed, Oct 1, 2014 at 3:45 PM, Andrey Ryabinin wrote: > On 10/01/2014 02:39 PM, Catalin Marinas wrote: >> On Mon, Sep 29, 2014 at 03:10:01PM +0100, Dmitry Vyukov wrote: >>> On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin >>> wrote: 2014-09-26 21:10 GMT+04:00 Dmitry Vyukov : > Looks

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Andrey Ryabinin
On 10/01/2014 02:39 PM, Catalin Marinas wrote: > On Mon, Sep 29, 2014 at 03:10:01PM +0100, Dmitry Vyukov wrote: >> On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin >> wrote: >>> 2014-09-26 21:10 GMT+04:00 Dmitry Vyukov : Looks good to me. We can disable kasan instrumentation of

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Catalin Marinas
On Mon, Sep 29, 2014 at 03:10:01PM +0100, Dmitry Vyukov wrote: > On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin > wrote: > > 2014-09-26 21:10 GMT+04:00 Dmitry Vyukov : > >> Looks good to me. > >> > >> We can disable kasan instrumentation of this file as well. > > > > Yes, but why? I don't

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Catalin Marinas
On Mon, Sep 29, 2014 at 03:10:01PM +0100, Dmitry Vyukov wrote: On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin ryabinin@gmail.com wrote: 2014-09-26 21:10 GMT+04:00 Dmitry Vyukov dvyu...@google.com: Looks good to me. We can disable kasan instrumentation of this file as well.

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Andrey Ryabinin
On 10/01/2014 02:39 PM, Catalin Marinas wrote: On Mon, Sep 29, 2014 at 03:10:01PM +0100, Dmitry Vyukov wrote: On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin ryabinin@gmail.com wrote: 2014-09-26 21:10 GMT+04:00 Dmitry Vyukov dvyu...@google.com: Looks good to me. We can disable kasan

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Dmitry Vyukov
On Wed, Oct 1, 2014 at 3:45 PM, Andrey Ryabinin a.ryabi...@samsung.com wrote: On 10/01/2014 02:39 PM, Catalin Marinas wrote: On Mon, Sep 29, 2014 at 03:10:01PM +0100, Dmitry Vyukov wrote: On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin ryabinin@gmail.com wrote: 2014-09-26 21:10

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Andrey Ryabinin
On 10/01/2014 05:27 PM, Dmitry Vyukov wrote: On Wed, Oct 1, 2014 at 3:45 PM, Andrey Ryabinin a.ryabi...@samsung.com wrote: On 10/01/2014 02:39 PM, Catalin Marinas wrote: On Mon, Sep 29, 2014 at 03:10:01PM +0100, Dmitry Vyukov wrote: On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-10-01 Thread Dmitry Vyukov
On Wed, Oct 1, 2014 at 6:11 PM, Andrey Ryabinin a.ryabi...@samsung.com wrote: We can disable kasan instrumentation of this file as well. Yes, but why? I don't think we need that. Just gut feeling. Such tools usually don't play well together. For example, due to asan quarantine lots of leaks

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-09-29 Thread Dmitry Vyukov
On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin wrote: > 2014-09-26 21:10 GMT+04:00 Dmitry Vyukov : >> Looks good to me. >> >> We can disable kasan instrumentation of this file as well. >> > > Yes, but why? I don't think we need that. Just gut feeling. Such tools usually don't play well

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-09-29 Thread Dmitry Vyukov
On Fri, Sep 26, 2014 at 9:36 PM, Andrey Ryabinin ryabinin@gmail.com wrote: 2014-09-26 21:10 GMT+04:00 Dmitry Vyukov dvyu...@google.com: Looks good to me. We can disable kasan instrumentation of this file as well. Yes, but why? I don't think we need that. Just gut feeling. Such tools

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-09-26 Thread Andrey Ryabinin
2014-09-26 21:10 GMT+04:00 Dmitry Vyukov : > Looks good to me. > > We can disable kasan instrumentation of this file as well. > Yes, but why? I don't think we need that. > On Wed, Sep 24, 2014 at 5:44 AM, Andrey Ryabinin > wrote: >> kmalloc internally round up allocation size, and kmemleak >>

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-09-26 Thread Dmitry Vyukov
Looks good to me. We can disable kasan instrumentation of this file as well. On Wed, Sep 24, 2014 at 5:44 AM, Andrey Ryabinin wrote: > kmalloc internally round up allocation size, and kmemleak > uses rounded up size as object's size. This makes kasan > to complain while kmemleak scans memory or

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-09-26 Thread Dmitry Vyukov
Looks good to me. We can disable kasan instrumentation of this file as well. On Wed, Sep 24, 2014 at 5:44 AM, Andrey Ryabinin a.ryabi...@samsung.com wrote: kmalloc internally round up allocation size, and kmemleak uses rounded up size as object's size. This makes kasan to complain while

Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-09-26 Thread Andrey Ryabinin
2014-09-26 21:10 GMT+04:00 Dmitry Vyukov dvyu...@google.com: Looks good to me. We can disable kasan instrumentation of this file as well. Yes, but why? I don't think we need that. On Wed, Sep 24, 2014 at 5:44 AM, Andrey Ryabinin a.ryabi...@samsung.com wrote: kmalloc internally round up

[PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-09-24 Thread Andrey Ryabinin
kmalloc internally round up allocation size, and kmemleak uses rounded up size as object's size. This makes kasan to complain while kmemleak scans memory or calculates of object's checksum. The simplest solution here is to disable kasan. Signed-off-by: Andrey Ryabinin --- mm/kmemleak.c | 6

[PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak

2014-09-24 Thread Andrey Ryabinin
kmalloc internally round up allocation size, and kmemleak uses rounded up size as object's size. This makes kasan to complain while kmemleak scans memory or calculates of object's checksum. The simplest solution here is to disable kasan. Signed-off-by: Andrey Ryabinin a.ryabi...@samsung.com ---