Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread bilhuang
On 12/19/2013 01:29 PM, Viresh Kumar wrote: On 19 December 2013 10:56, bilhuang wrote: I'm not sure virtual regulator for CPU is a good idea, in addition to that, we don't have a single SoC OPP table, we need several which are speedo-id and process-id dependant, but generic cpufreq-cpu0 is

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread Viresh Kumar
On 19 December 2013 10:56, bilhuang wrote: > I'm not sure virtual regulator for CPU is a good idea, in addition to that, > we don't have a single SoC OPP table, we need several which are speedo-id > and process-id dependant, but generic cpufreq-cpu0 is assuming there is only > one statically

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread bilhuang
On 12/18/2013 10:39 PM, Viresh Kumar wrote: On 18 December 2013 17:03, bilhuang wrote: cpufreq-cpu0 driver will call regulator_set_voltage_tol() directly according to the pre-defined OPP freq/volt pairs, the regulator drivers could be shared by other SoC so is not suitable to handle this, or

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread Viresh Kumar
On 18 December 2013 17:03, bilhuang wrote: > cpufreq-cpu0 driver will call regulator_set_voltage_tol() directly according > to the pre-defined OPP freq/volt pairs, the regulator drivers could be > shared by other SoC so is not suitable to handle this, or do I > misunderstand? In case regulator's

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread bilhuang
On 12/18/2013 07:11 PM, Viresh Kumar wrote: On 17 December 2013 16:22, bilhuang wrote: Tegra20 DVFS is a little bit complicated due to the fact that we can't scale VDD_CPU directly, there are constraints or relationship to other power rails so I don't think it is a good idea to use generic

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread Viresh Kumar
On 17 December 2013 16:22, bilhuang wrote: > Tegra20 DVFS is a little bit complicated due to the fact that we can't scale > VDD_CPU directly, there are constraints or relationship to other power rails > so I don't think it is a good idea to use generic cpufreq-cpu0 driver if > we're going to

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread Viresh Kumar
On 17 December 2013 16:22, bilhuang bilhu...@nvidia.com wrote: Tegra20 DVFS is a little bit complicated due to the fact that we can't scale VDD_CPU directly, there are constraints or relationship to other power rails so I don't think it is a good idea to use generic cpufreq-cpu0 driver if

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread bilhuang
On 12/18/2013 07:11 PM, Viresh Kumar wrote: On 17 December 2013 16:22, bilhuang bilhu...@nvidia.com wrote: Tegra20 DVFS is a little bit complicated due to the fact that we can't scale VDD_CPU directly, there are constraints or relationship to other power rails so I don't think it is a good idea

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread Viresh Kumar
On 18 December 2013 17:03, bilhuang bilhu...@nvidia.com wrote: cpufreq-cpu0 driver will call regulator_set_voltage_tol() directly according to the pre-defined OPP freq/volt pairs, the regulator drivers could be shared by other SoC so is not suitable to handle this, or do I misunderstand? In

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread bilhuang
On 12/18/2013 10:39 PM, Viresh Kumar wrote: On 18 December 2013 17:03, bilhuang bilhu...@nvidia.com wrote: cpufreq-cpu0 driver will call regulator_set_voltage_tol() directly according to the pre-defined OPP freq/volt pairs, the regulator drivers could be shared by other SoC so is not suitable

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread Viresh Kumar
On 19 December 2013 10:56, bilhuang bilhu...@nvidia.com wrote: I'm not sure virtual regulator for CPU is a good idea, in addition to that, we don't have a single SoC OPP table, we need several which are speedo-id and process-id dependant, but generic cpufreq-cpu0 is assuming there is only one

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-18 Thread bilhuang
On 12/19/2013 01:29 PM, Viresh Kumar wrote: On 19 December 2013 10:56, bilhuang bilhu...@nvidia.com wrote: I'm not sure virtual regulator for CPU is a good idea, in addition to that, we don't have a single SoC OPP table, we need several which are speedo-id and process-id dependant, but generic

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-17 Thread bilhuang
On 12/17/2013 02:54 PM, Viresh Kumar wrote: On 5 December 2013 13:14, Bill Huang wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into tegra20-cpufreq.c. * Bind Tegra cpufreq dirver

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-17 Thread bilhuang
On 12/17/2013 02:54 PM, Viresh Kumar wrote: On 5 December 2013 13:14, Bill Huang bilhu...@nvidia.com wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into tegra20-cpufreq.c. * Bind

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-16 Thread Viresh Kumar
On 5 December 2013 13:14, Bill Huang wrote: > Re-model Tegra cpufreq driver to support all Tegra series of SoCs. > > * Make tegra-cpufreq.c a generic Tegra cpufreq driver. > * Move Tegra20 specific codes into tegra20-cpufreq.c. > * Bind Tegra cpufreq dirver with a fake device so defer probe would

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-16 Thread Viresh Kumar
On 5 December 2013 13:14, Bill Huang bilhu...@nvidia.com wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into tegra20-cpufreq.c. * Bind Tegra cpufreq dirver with a fake device so

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-11 Thread Stephen Warren
On 12/11/2013 04:18 AM, bilhuang wrote: > On 12/10/2013 01:32 AM, Stephen Warren wrote: >> On 12/09/2013 01:44 AM, bilhuang wrote: >>> On 12/06/2013 07:04 AM, Stephen Warren wrote: On 12/05/2013 12:44 AM, Bill Huang wrote: > Re-model Tegra cpufreq driver to support all Tegra series of

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-11 Thread bilhuang
On 12/10/2013 01:32 AM, Stephen Warren wrote: On 12/09/2013 01:44 AM, bilhuang wrote: On 12/06/2013 07:04 AM, Stephen Warren wrote: On 12/05/2013 12:44 AM, Bill Huang wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-11 Thread bilhuang
On 12/10/2013 01:32 AM, Stephen Warren wrote: On 12/09/2013 01:44 AM, bilhuang wrote: On 12/06/2013 07:04 AM, Stephen Warren wrote: On 12/05/2013 12:44 AM, Bill Huang wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-11 Thread Stephen Warren
On 12/11/2013 04:18 AM, bilhuang wrote: On 12/10/2013 01:32 AM, Stephen Warren wrote: On 12/09/2013 01:44 AM, bilhuang wrote: On 12/06/2013 07:04 AM, Stephen Warren wrote: On 12/05/2013 12:44 AM, Bill Huang wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-09 Thread Stephen Warren
On 12/09/2013 01:44 AM, bilhuang wrote: > On 12/06/2013 07:04 AM, Stephen Warren wrote: >> On 12/05/2013 12:44 AM, Bill Huang wrote: >>> Re-model Tegra cpufreq driver to support all Tegra series of SoCs. >>> >>> * Make tegra-cpufreq.c a generic Tegra cpufreq driver. >>> * Move Tegra20 specific

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-09 Thread bilhuang
On 12/06/2013 07:04 AM, Stephen Warren wrote: On 12/05/2013 12:44 AM, Bill Huang wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into tegra20-cpufreq.c. * Bind Tegra cpufreq dirver

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-09 Thread bilhuang
On 12/06/2013 07:04 AM, Stephen Warren wrote: On 12/05/2013 12:44 AM, Bill Huang wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into tegra20-cpufreq.c. * Bind Tegra cpufreq dirver

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-09 Thread Stephen Warren
On 12/09/2013 01:44 AM, bilhuang wrote: On 12/06/2013 07:04 AM, Stephen Warren wrote: On 12/05/2013 12:44 AM, Bill Huang wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-05 Thread Stephen Warren
On 12/05/2013 12:44 AM, Bill Huang wrote: > Re-model Tegra cpufreq driver to support all Tegra series of SoCs. > > * Make tegra-cpufreq.c a generic Tegra cpufreq driver. > * Move Tegra20 specific codes into tegra20-cpufreq.c. > * Bind Tegra cpufreq dirver with a fake device so defer probe would

Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-05 Thread Stephen Warren
On 12/05/2013 12:44 AM, Bill Huang wrote: Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into tegra20-cpufreq.c. * Bind Tegra cpufreq dirver with a fake device so defer probe would work

[PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-04 Thread Bill Huang
Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into tegra20-cpufreq.c. * Bind Tegra cpufreq dirver with a fake device so defer probe would work when we're going to get regulator in the

[PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

2013-12-04 Thread Bill Huang
Re-model Tegra cpufreq driver to support all Tegra series of SoCs. * Make tegra-cpufreq.c a generic Tegra cpufreq driver. * Move Tegra20 specific codes into tegra20-cpufreq.c. * Bind Tegra cpufreq dirver with a fake device so defer probe would work when we're going to get regulator in the