Re: [PATCH v3 2/2] drm/mediatek: set mt8173 dithering function

2016-07-20 Thread CK Hu
Hi, Bibby: On Thu, 2016-07-21 at 11:21 +0800, Bibby Hsieh wrote: > Hi, CK > > I'm appreciate your comments. > > [snip...] > > > > > > @@ -469,7 +484,7 @@ void mtk_crtc_ddp_irq(struct drm_crtc *crtc, struct > > > mtk_ddp_comp *ovl) > > > if (state->pending_config) { > > >

Re: [PATCH v3 2/2] drm/mediatek: set mt8173 dithering function

2016-07-20 Thread CK Hu
Hi, Bibby: On Thu, 2016-07-21 at 11:21 +0800, Bibby Hsieh wrote: > Hi, CK > > I'm appreciate your comments. > > [snip...] > > > > > > @@ -469,7 +484,7 @@ void mtk_crtc_ddp_irq(struct drm_crtc *crtc, struct > > > mtk_ddp_comp *ovl) > > > if (state->pending_config) { > > >

Re: [PATCH v3 2/2] drm/mediatek: set mt8173 dithering function

2016-07-20 Thread Bibby Hsieh
Hi, CK I'm appreciate your comments. On Mon, 2016-07-18 at 10:33 +0800, CK Hu wrote: > Hi, Bibby: > > Some comments inline. > > On Thu, 2016-07-07 at 15:37 +0800, Bibby Hsieh wrote: > > Some panels only accept bpc (bit per color) 6-bit. > > But, the default bpc in mt8173 display data path is

Re: [PATCH v3 2/2] drm/mediatek: set mt8173 dithering function

2016-07-20 Thread Bibby Hsieh
Hi, CK I'm appreciate your comments. On Mon, 2016-07-18 at 10:33 +0800, CK Hu wrote: > Hi, Bibby: > > Some comments inline. > > On Thu, 2016-07-07 at 15:37 +0800, Bibby Hsieh wrote: > > Some panels only accept bpc (bit per color) 6-bit. > > But, the default bpc in mt8173 display data path is

Re: [PATCH v3 2/2] drm/mediatek: set mt8173 dithering function

2016-07-17 Thread CK Hu
Hi, Bibby: Some comments inline. On Thu, 2016-07-07 at 15:37 +0800, Bibby Hsieh wrote: > Some panels only accept bpc (bit per color) 6-bit. > But, the default bpc in mt8173 display data path is 8-bit. > If we didn't enable dithering function to convert bpc, > display cannot show the smooth

Re: [PATCH v3 2/2] drm/mediatek: set mt8173 dithering function

2016-07-17 Thread CK Hu
Hi, Bibby: Some comments inline. On Thu, 2016-07-07 at 15:37 +0800, Bibby Hsieh wrote: > Some panels only accept bpc (bit per color) 6-bit. > But, the default bpc in mt8173 display data path is 8-bit. > If we didn't enable dithering function to convert bpc, > display cannot show the smooth

[PATCH v3 2/2] drm/mediatek: set mt8173 dithering function

2016-07-07 Thread Bibby Hsieh
Some panels only accept bpc (bit per color) 6-bit. But, the default bpc in mt8173 display data path is 8-bit. If we didn't enable dithering function to convert bpc, display cannot show the smooth grayscale image. In mt8173, the dithering function in OD (OverDrive) and GAMMA module, we have to

[PATCH v3 2/2] drm/mediatek: set mt8173 dithering function

2016-07-07 Thread Bibby Hsieh
Some panels only accept bpc (bit per color) 6-bit. But, the default bpc in mt8173 display data path is 8-bit. If we didn't enable dithering function to convert bpc, display cannot show the smooth grayscale image. In mt8173, the dithering function in OD (OverDrive) and GAMMA module, we have to