Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-27 Thread Linus Walleij
On Mon, Jan 26, 2015 at 4:57 PM, Sascha Hauer wrote: > On Tue, Jan 20, 2015 at 10:45:09AM +0100, Linus Walleij wrote: >> As discussed with Sascha Hauer it is ambigous to use "pins" for >> a numerical value indicating both a mux setting and a pin. Sascha >> suggests using "pinmux" and adding this

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-27 Thread Linus Walleij
On Mon, Jan 26, 2015 at 4:57 PM, Sascha Hauer s.ha...@pengutronix.de wrote: On Tue, Jan 20, 2015 at 10:45:09AM +0100, Linus Walleij wrote: As discussed with Sascha Hauer it is ambigous to use pins for a numerical value indicating both a mux setting and a pin. Sascha suggests using pinmux and

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-26 Thread Sascha Hauer
Hi Linus, On Tue, Jan 20, 2015 at 10:45:09AM +0100, Linus Walleij wrote: > On Fri, Jan 16, 2015 at 11:23 AM, Yingjoe Chen > wrote: > > On Fri, 2015-01-16 at 10:53 +0100, Linus Walleij wrote: > >> On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer > >> wrote: > >> > On Tue, Jan 13, 2015 at

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-26 Thread Sascha Hauer
Hi Linus, On Tue, Jan 20, 2015 at 10:45:09AM +0100, Linus Walleij wrote: On Fri, Jan 16, 2015 at 11:23 AM, Yingjoe Chen yingjoe.c...@mediatek.com wrote: On Fri, 2015-01-16 at 10:53 +0100, Linus Walleij wrote: On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer s.ha...@pengutronix.de wrote:

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-20 Thread Linus Walleij
On Fri, Jan 16, 2015 at 11:23 AM, Yingjoe Chen wrote: > On Fri, 2015-01-16 at 10:53 +0100, Linus Walleij wrote: >> On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer wrote: >> > On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: >> >> >> > You often talk about ambiguities. Could you give

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-20 Thread Linus Walleij
On Fri, Jan 16, 2015 at 11:23 AM, Yingjoe Chen yingjoe.c...@mediatek.com wrote: On Fri, 2015-01-16 at 10:53 +0100, Linus Walleij wrote: On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer s.ha...@pengutronix.de wrote: On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: You often talk

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-16 Thread Yingjoe Chen
On Fri, 2015-01-16 at 10:53 +0100, Linus Walleij wrote: > On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer wrote: > > On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: > > >> > You often talk about ambiguities. Could you give an example what > >> > ambiguities you mean? > >> > >> What

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-16 Thread Linus Walleij
On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer wrote: > On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: >> > You often talk about ambiguities. Could you give an example what >> > ambiguities you mean? >> >> What happened was this pins = ; arguments were sometimes >> strings and

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-16 Thread Linus Walleij
On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer s.ha...@pengutronix.de wrote: On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: You often talk about ambiguities. Could you give an example what ambiguities you mean? What happened was this pins = ; arguments were sometimes

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-16 Thread Yingjoe Chen
On Fri, 2015-01-16 at 10:53 +0100, Linus Walleij wrote: On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer s.ha...@pengutronix.de wrote: On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: You often talk about ambiguities. Could you give an example what ambiguities you mean?

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-13 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jan 14, 2015, at 12:16 AM, Sascha Hauer wrote: > > On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: I am worried that there is something in your reasoning that sort of assumes all pin controllers mux pins one-by-one and not in groups. How do we make it

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-13 Thread Sascha Hauer
On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: > >> I am worried that there is something in your reasoning that sort of > >> assumes all pin controllers mux pins one-by-one and not in groups. > >> How do we make it impossible to write a device tree that also > >> make hardware that

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-13 Thread Linus Walleij
On Mon, Jan 12, 2015 at 1:22 PM, Sascha Hauer wrote: > On Sat, Jan 10, 2015 at 10:33:46PM +0100, Linus Walleij wrote: >> On Tue, Dec 2, 2014 at 2:55 PM, Sascha Hauer wrote: >> > For the SSP0 it needs the string "ssp0_a_1" which is documented exactly >> > nowhere. >> >> Is this a bug report

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-13 Thread Jean-Christophe PLAGNIOL-VILLARD
On Jan 14, 2015, at 12:16 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: I am worried that there is something in your reasoning that sort of assumes all pin controllers mux pins one-by-one and not in groups. How do we make it

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-13 Thread Linus Walleij
On Mon, Jan 12, 2015 at 1:22 PM, Sascha Hauer s.ha...@pengutronix.de wrote: On Sat, Jan 10, 2015 at 10:33:46PM +0100, Linus Walleij wrote: On Tue, Dec 2, 2014 at 2:55 PM, Sascha Hauer s.ha...@pengutronix.de wrote: For the SSP0 it needs the string ssp0_a_1 which is documented exactly

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-13 Thread Sascha Hauer
On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: I am worried that there is something in your reasoning that sort of assumes all pin controllers mux pins one-by-one and not in groups. How do we make it impossible to write a device tree that also make hardware that do

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-12 Thread Sascha Hauer
Hi Linus, On Sat, Jan 10, 2015 at 10:33:46PM +0100, Linus Walleij wrote: > On Tue, Dec 2, 2014 at 2:55 PM, Sascha Hauer wrote: > > Sorry for taking eternities to get back on this, I ran into a merge window > and some christmas. I do hope we can resolve this in the current > development cycle so

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-12 Thread Sascha Hauer
Hi Linus, On Sat, Jan 10, 2015 at 10:33:46PM +0100, Linus Walleij wrote: On Tue, Dec 2, 2014 at 2:55 PM, Sascha Hauer s.ha...@pengutronix.de wrote: Sorry for taking eternities to get back on this, I ran into a merge window and some christmas. I do hope we can resolve this in the current

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-10 Thread Linus Walleij
On Tue, Dec 2, 2014 at 2:55 PM, Sascha Hauer wrote: Sorry for taking eternities to get back on this, I ran into a merge window and some christmas. I do hope we can resolve this in the current development cycle so we can get this support in. > On Fri, Nov 28, 2014 at 05:12:44PM +0100, Linus

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-10 Thread Linus Walleij
On Tue, Dec 2, 2014 at 2:55 PM, Sascha Hauer s.ha...@pengutronix.de wrote: Sorry for taking eternities to get back on this, I ran into a merge window and some christmas. I do hope we can resolve this in the current development cycle so we can get this support in. On Fri, Nov 28, 2014 at

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2014-12-02 Thread Sascha Hauer
Hi Linus, On Fri, Nov 28, 2014 at 05:12:44PM +0100, Linus Walleij wrote: > On Thu, Nov 27, 2014 at 11:18 AM, Sascha Hauer wrote: > > On Thu, Nov 27, 2014 at 09:44:42AM +0100, Linus Walleij wrote: > >> On Tue, Nov 11, 2014 at 1:38 PM, Hongzhou Yang > >> wrote: > > >> > +- mediatek,pins: 2

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2014-12-02 Thread Sascha Hauer
Hi Linus, On Fri, Nov 28, 2014 at 05:12:44PM +0100, Linus Walleij wrote: On Thu, Nov 27, 2014 at 11:18 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Thu, Nov 27, 2014 at 09:44:42AM +0100, Linus Walleij wrote: On Tue, Nov 11, 2014 at 1:38 PM, Hongzhou Yang hongzhou.y...@mediatek.com

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2014-11-28 Thread Linus Walleij
On Thu, Nov 27, 2014 at 11:18 AM, Sascha Hauer wrote: > On Thu, Nov 27, 2014 at 09:44:42AM +0100, Linus Walleij wrote: >> On Tue, Nov 11, 2014 at 1:38 PM, Hongzhou Yang >> wrote: >> > +- mediatek,pins: 2 integers array, represents gpio pinmux number and >> > config >> > + setting. The format

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2014-11-28 Thread Linus Walleij
On Thu, Nov 27, 2014 at 11:18 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Thu, Nov 27, 2014 at 09:44:42AM +0100, Linus Walleij wrote: On Tue, Nov 11, 2014 at 1:38 PM, Hongzhou Yang hongzhou.y...@mediatek.com wrote: +- mediatek,pins: 2 integers array, represents gpio pinmux number and

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2014-11-27 Thread Sascha Hauer
On Thu, Nov 27, 2014 at 09:44:42AM +0100, Linus Walleij wrote: > On Tue, Nov 11, 2014 at 1:38 PM, Hongzhou Yang > wrote: > > > +* Mediatek MT65XX Pin Controller > > + > > +The Mediatek's Pin controller is used to control GPIO pins. > > It's not GPIO pins, since they are not always general

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2014-11-27 Thread Linus Walleij
On Tue, Nov 11, 2014 at 1:38 PM, Hongzhou Yang wrote: > +* Mediatek MT65XX Pin Controller > + > +The Mediatek's Pin controller is used to control GPIO pins. It's not GPIO pins, since they are not always general purpose. It's just pins. Say "control SoC pins". > +Required properties: > +-

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2014-11-27 Thread Linus Walleij
On Tue, Nov 11, 2014 at 1:38 PM, Hongzhou Yang hongzhou.y...@mediatek.com wrote: +* Mediatek MT65XX Pin Controller + +The Mediatek's Pin controller is used to control GPIO pins. It's not GPIO pins, since they are not always general purpose. It's just pins. Say control SoC pins. +Required

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2014-11-27 Thread Sascha Hauer
On Thu, Nov 27, 2014 at 09:44:42AM +0100, Linus Walleij wrote: On Tue, Nov 11, 2014 at 1:38 PM, Hongzhou Yang hongzhou.y...@mediatek.com wrote: +* Mediatek MT65XX Pin Controller + +The Mediatek's Pin controller is used to control GPIO pins. It's not GPIO pins, since they are not