Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-21 Thread Jacek Anaszewski
On 11/21/2017 12:22 AM, Pavel Machek wrote: > On Mon 2017-11-20 13:10:33, Bjorn Andersson wrote: >> On Sun 19 Nov 13:36 PST 2017, Jacek Anaszewski wrote: >> >>> Hi Bjorn, >>> >>> Thanks for the patch. Please refer to my comments in the code. >>> >>> On 11/15/2017 08:13 AM, Bjorn Andersson wrote:

Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-21 Thread Jacek Anaszewski
On 11/21/2017 12:22 AM, Pavel Machek wrote: > On Mon 2017-11-20 13:10:33, Bjorn Andersson wrote: >> On Sun 19 Nov 13:36 PST 2017, Jacek Anaszewski wrote: >> >>> Hi Bjorn, >>> >>> Thanks for the patch. Please refer to my comments in the code. >>> >>> On 11/15/2017 08:13 AM, Bjorn Andersson wrote:

Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-21 Thread Jacek Anaszewski
On 11/20/2017 10:10 PM, Bjorn Andersson wrote: > On Sun 19 Nov 13:36 PST 2017, Jacek Anaszewski wrote: > >> Hi Bjorn, >> >> Thanks for the patch. Please refer to my comments in the code. >> >> On 11/15/2017 08:13 AM, Bjorn Andersson wrote: > [..] >>> diff --git a/drivers/leds/Kconfig

Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-21 Thread Jacek Anaszewski
On 11/20/2017 10:10 PM, Bjorn Andersson wrote: > On Sun 19 Nov 13:36 PST 2017, Jacek Anaszewski wrote: > >> Hi Bjorn, >> >> Thanks for the patch. Please refer to my comments in the code. >> >> On 11/15/2017 08:13 AM, Bjorn Andersson wrote: > [..] >>> diff --git a/drivers/leds/Kconfig

Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-20 Thread Pavel Machek
On Mon 2017-11-20 13:10:33, Bjorn Andersson wrote: > On Sun 19 Nov 13:36 PST 2017, Jacek Anaszewski wrote: > > > Hi Bjorn, > > > > Thanks for the patch. Please refer to my comments in the code. > > > > On 11/15/2017 08:13 AM, Bjorn Andersson wrote: > [..] > > > diff --git a/drivers/leds/Kconfig

Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-20 Thread Pavel Machek
On Mon 2017-11-20 13:10:33, Bjorn Andersson wrote: > On Sun 19 Nov 13:36 PST 2017, Jacek Anaszewski wrote: > > > Hi Bjorn, > > > > Thanks for the patch. Please refer to my comments in the code. > > > > On 11/15/2017 08:13 AM, Bjorn Andersson wrote: > [..] > > > diff --git a/drivers/leds/Kconfig

Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-20 Thread Bjorn Andersson
On Sun 19 Nov 13:36 PST 2017, Jacek Anaszewski wrote: > Hi Bjorn, > > Thanks for the patch. Please refer to my comments in the code. > > On 11/15/2017 08:13 AM, Bjorn Andersson wrote: [..] > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > > index 52ea34e337cd..ccc3aa4b2474 100644 >

Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-20 Thread Bjorn Andersson
On Sun 19 Nov 13:36 PST 2017, Jacek Anaszewski wrote: > Hi Bjorn, > > Thanks for the patch. Please refer to my comments in the code. > > On 11/15/2017 08:13 AM, Bjorn Andersson wrote: [..] > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > > index 52ea34e337cd..ccc3aa4b2474 100644 >

Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-19 Thread Jacek Anaszewski
Hi Bjorn, Thanks for the patch. Please refer to my comments in the code. On 11/15/2017 08:13 AM, Bjorn Andersson wrote: > The Light Pulse Generator (LPG) is a PWM-block found in a wide range of > PMICs from Qualcomm. It can operate on fixed parameters or based on a > lookup-table, altering the

Re: [PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-19 Thread Jacek Anaszewski
Hi Bjorn, Thanks for the patch. Please refer to my comments in the code. On 11/15/2017 08:13 AM, Bjorn Andersson wrote: > The Light Pulse Generator (LPG) is a PWM-block found in a wide range of > PMICs from Qualcomm. It can operate on fixed parameters or based on a > lookup-table, altering the

[PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-14 Thread Bjorn Andersson
The Light Pulse Generator (LPG) is a PWM-block found in a wide range of PMICs from Qualcomm. It can operate on fixed parameters or based on a lookup-table, altering the duty cycle over time - which provides the means for e.g. hardware assisted transitions of LED brightness. Signed-off-by: Bjorn

[PATCH v3 2/3] leds: Add driver for Qualcomm LPG

2017-11-14 Thread Bjorn Andersson
The Light Pulse Generator (LPG) is a PWM-block found in a wide range of PMICs from Qualcomm. It can operate on fixed parameters or based on a lookup-table, altering the duty cycle over time - which provides the means for e.g. hardware assisted transitions of LED brightness. Signed-off-by: Bjorn