Re: [PATCH v3 2/4] regulator: core: manage enable GPIO list

2013-02-18 Thread Axel Lin
> +/** > + * Balance enable_count of each GPIO and actual GPIO pin control. > + * GPIO is enabled in case of initial use. (enable_count is 0) > + * GPIO is disabled when it is not shared any more. (enable_count <= 1) I think you mean "GPIO is disabled when it is not used any more." "It is not

Re: [PATCH v3 2/4] regulator: core: manage enable GPIO list

2013-02-18 Thread Axel Lin
+/** + * Balance enable_count of each GPIO and actual GPIO pin control. + * GPIO is enabled in case of initial use. (enable_count is 0) + * GPIO is disabled when it is not shared any more. (enable_count = 1) I think you mean GPIO is disabled when it is not used any more. It is not shared

[PATCH v3 2/4] regulator: core: manage enable GPIO list

2013-02-17 Thread Kim, Milo
To support shared enable GPIO pin, replace GPIO code with new static functions Reference count: 'enable_count' Balance the reference count of each GPIO and actual pin control. The count is incremented with enabling GPIO. On the other hand, it is decremented on disabling GPIO. Actual

[PATCH v3 2/4] regulator: core: manage enable GPIO list

2013-02-17 Thread Kim, Milo
To support shared enable GPIO pin, replace GPIO code with new static functions Reference count: 'enable_count' Balance the reference count of each GPIO and actual pin control. The count is incremented with enabling GPIO. On the other hand, it is decremented on disabling GPIO. Actual