Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Hoan Tran
On Thu, Jun 22, 2017 at 11:17 AM, Mark Rutland wrote: > On Thu, Jun 22, 2017 at 11:13:08AM -0700, Hoan Tran wrote: >> On Thu, Jun 22, 2017 at 10:52 AM, Mark Rutland wrote: >> > On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: >> > > static

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Hoan Tran
On Thu, Jun 22, 2017 at 11:17 AM, Mark Rutland wrote: > On Thu, Jun 22, 2017 at 11:13:08AM -0700, Hoan Tran wrote: >> On Thu, Jun 22, 2017 at 10:52 AM, Mark Rutland wrote: >> > On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: >> > > static inline void >> > >

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Hoan Tran
Hi Mark, On Thu, Jun 22, 2017 at 11:18 AM, Mark Rutland wrote: > On Thu, Jun 22, 2017 at 06:52:56PM +0100, Mark Rutland wrote: >> Hi Hoan, >> >> This largely looks good; I have one minor comment. >> >> On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: >> > static

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Hoan Tran
Hi Mark, On Thu, Jun 22, 2017 at 11:18 AM, Mark Rutland wrote: > On Thu, Jun 22, 2017 at 06:52:56PM +0100, Mark Rutland wrote: >> Hi Hoan, >> >> This largely looks good; I have one minor comment. >> >> On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: >> > static inline void >> >

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Mark Rutland
On Thu, Jun 22, 2017 at 06:52:56PM +0100, Mark Rutland wrote: > Hi Hoan, > > This largely looks good; I have one minor comment. > > On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: > > static inline void > > +xgene_pmu_write_counter64(struct xgene_pmu_dev *pmu_dev, int idx, u64 val) >

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Mark Rutland
On Thu, Jun 22, 2017 at 06:52:56PM +0100, Mark Rutland wrote: > Hi Hoan, > > This largely looks good; I have one minor comment. > > On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: > > static inline void > > +xgene_pmu_write_counter64(struct xgene_pmu_dev *pmu_dev, int idx, u64 val) >

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Mark Rutland
On Thu, Jun 22, 2017 at 11:13:08AM -0700, Hoan Tran wrote: > On Thu, Jun 22, 2017 at 10:52 AM, Mark Rutland wrote: > > On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: > > > static inline void > > > +xgene_pmu_write_counter64(struct xgene_pmu_dev *pmu_dev, int

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Mark Rutland
On Thu, Jun 22, 2017 at 11:13:08AM -0700, Hoan Tran wrote: > On Thu, Jun 22, 2017 at 10:52 AM, Mark Rutland wrote: > > On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: > > > static inline void > > > +xgene_pmu_write_counter64(struct xgene_pmu_dev *pmu_dev, int idx, u64 > > > val) > >

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Hoan Tran
Hi Mark, On Thu, Jun 22, 2017 at 10:52 AM, Mark Rutland wrote: > > Hi Hoan, > > This largely looks good; I have one minor comment. > > On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: > > static inline void > > +xgene_pmu_write_counter64(struct xgene_pmu_dev

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Hoan Tran
Hi Mark, On Thu, Jun 22, 2017 at 10:52 AM, Mark Rutland wrote: > > Hi Hoan, > > This largely looks good; I have one minor comment. > > On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: > > static inline void > > +xgene_pmu_write_counter64(struct xgene_pmu_dev *pmu_dev, int idx, u64

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Mark Rutland
Hi Hoan, This largely looks good; I have one minor comment. On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: > static inline void > +xgene_pmu_write_counter64(struct xgene_pmu_dev *pmu_dev, int idx, u64 val) > +{ > + u32 cnt_lo, cnt_hi; > + > + cnt_hi = upper_32_bits(val); > +

Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-22 Thread Mark Rutland
Hi Hoan, This largely looks good; I have one minor comment. On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote: > static inline void > +xgene_pmu_write_counter64(struct xgene_pmu_dev *pmu_dev, int idx, u64 val) > +{ > + u32 cnt_lo, cnt_hi; > + > + cnt_hi = upper_32_bits(val); > +

[PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-06 Thread Hoan Tran
This patch adds support for SoC-wide (AKA uncore) Performance Monitoring Unit version 3. It can support up to - 2 IOB PMU instances - 8 L3C PMU instances - 2 MCB PMU instances - 8 MCU PMU instances and these PMUs support 64 bit counter Signed-off-by: Hoan Tran ---

[PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3

2017-06-06 Thread Hoan Tran
This patch adds support for SoC-wide (AKA uncore) Performance Monitoring Unit version 3. It can support up to - 2 IOB PMU instances - 8 L3C PMU instances - 2 MCB PMU instances - 8 MCU PMU instances and these PMUs support 64 bit counter Signed-off-by: Hoan Tran --- drivers/perf/xgene_pmu.c