Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-14 Thread Pali Rohár
On Friday 14 November 2014 12:22:33 Pali Rohár wrote: > On Sunday 09 November 2014 12:30:03 Pali Rohár wrote: > > On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: > > > Hi Pali, > > > > > > On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: > > > > int alps_detect(struct

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-14 Thread Pali Rohár
On Sunday 09 November 2014 12:30:03 Pali Rohár wrote: > On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: > > Hi Pali, > > > > On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: > > > int alps_detect(struct psmouse *psmouse, bool > > > set_properties) { > > > > > > - struct

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-14 Thread Pali Rohár
On Sunday 09 November 2014 12:30:03 Pali Rohár wrote: On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: Hi Pali, On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: int alps_detect(struct psmouse *psmouse, bool set_properties) { - struct alps_data dummy;

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-14 Thread Pali Rohár
On Friday 14 November 2014 12:22:33 Pali Rohár wrote: On Sunday 09 November 2014 12:30:03 Pali Rohár wrote: On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: Hi Pali, On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: int alps_detect(struct psmouse *psmouse,

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-09 Thread Pali Rohár
On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: > Hi Pali, > > On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: > > int alps_detect(struct psmouse *psmouse, bool > > set_properties) { > > > > - struct alps_data dummy; > > + unsigned char e6[4]; > > > > - if

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-09 Thread Dmitry Torokhov
Hi Pali, On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: > int alps_detect(struct psmouse *psmouse, bool set_properties) > { > - struct alps_data dummy; > + unsigned char e6[4]; > > - if (alps_identify(psmouse, ) < 0) > - return -1; > + /* > + *

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-09 Thread Dmitry Torokhov
Hi Pali, On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: int alps_detect(struct psmouse *psmouse, bool set_properties) { - struct alps_data dummy; + unsigned char e6[4]; - if (alps_identify(psmouse, dummy) 0) - return -1; + /* + * Try E6

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-09 Thread Pali Rohár
On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: Hi Pali, On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: int alps_detect(struct psmouse *psmouse, bool set_properties) { - struct alps_data dummy; + unsigned char e6[4]; - if (alps_identify(psmouse,

[PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-01 Thread Pali Rohár
On some laptops after starting them from off state (not after reboot), function alps_probe_trackstick_v3() (called from function alps_identify()) does not detect trackstick. To fix this problem we need to reset device. But function alps_identify() is called also from alps_detect() and we do not

[PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-01 Thread Pali Rohár
On some laptops after starting them from off state (not after reboot), function alps_probe_trackstick_v3() (called from function alps_identify()) does not detect trackstick. To fix this problem we need to reset device. But function alps_identify() is called also from alps_detect() and we do not