Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-10-13 Thread Joonsoo Kim
On Thu, Oct 02, 2014 at 10:47:51AM -0400, Dan Streetman wrote: > >> I think that using ref would makes intuitive code. Although there is > >> some memory overhead, it is really small. So I prefer to this way. > >> > >> But, if you think that removing ref is better, I will do it. > >> Please let me

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-10-13 Thread Joonsoo Kim
On Thu, Oct 02, 2014 at 10:47:51AM -0400, Dan Streetman wrote: I think that using ref would makes intuitive code. Although there is some memory overhead, it is really small. So I prefer to this way. But, if you think that removing ref is better, I will do it. Please let me know your

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-10-02 Thread Dan Streetman
On Thu, Oct 2, 2014 at 1:44 AM, Minchan Kim wrote: > On Thu, Oct 02, 2014 at 02:39:49PM +0900, Joonsoo Kim wrote: >> On Tue, Sep 30, 2014 at 08:10:22AM +0900, Minchan Kim wrote: >> > Hey Joonsoo, >> > >> > On Mon, Sep 29, 2014 at 04:45:27PM +0900, Joonsoo Kim wrote: >> > > zsmalloc has many

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-10-02 Thread Dan Streetman
On Thu, Oct 2, 2014 at 1:44 AM, Minchan Kim minchan@lge.com wrote: On Thu, Oct 02, 2014 at 02:39:49PM +0900, Joonsoo Kim wrote: On Tue, Sep 30, 2014 at 08:10:22AM +0900, Minchan Kim wrote: Hey Joonsoo, On Mon, Sep 29, 2014 at 04:45:27PM +0900, Joonsoo Kim wrote: zsmalloc has many

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-10-01 Thread Minchan Kim
On Thu, Oct 02, 2014 at 02:39:49PM +0900, Joonsoo Kim wrote: > On Tue, Sep 30, 2014 at 08:10:22AM +0900, Minchan Kim wrote: > > Hey Joonsoo, > > > > On Mon, Sep 29, 2014 at 04:45:27PM +0900, Joonsoo Kim wrote: > > > zsmalloc has many size_classes to reduce fragmentation and they are > > > in 16

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-10-01 Thread Joonsoo Kim
On Tue, Sep 30, 2014 at 08:10:22AM +0900, Minchan Kim wrote: > Hey Joonsoo, > > On Mon, Sep 29, 2014 at 04:45:27PM +0900, Joonsoo Kim wrote: > > zsmalloc has many size_classes to reduce fragmentation and they are > > in 16 bytes unit, for example, 16, 32, 48, etc., if PAGE_SIZE is 4096. > > And,

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-10-01 Thread Joonsoo Kim
On Tue, Sep 30, 2014 at 08:10:22AM +0900, Minchan Kim wrote: Hey Joonsoo, On Mon, Sep 29, 2014 at 04:45:27PM +0900, Joonsoo Kim wrote: zsmalloc has many size_classes to reduce fragmentation and they are in 16 bytes unit, for example, 16, 32, 48, etc., if PAGE_SIZE is 4096. And, zsmalloc

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-10-01 Thread Minchan Kim
On Thu, Oct 02, 2014 at 02:39:49PM +0900, Joonsoo Kim wrote: On Tue, Sep 30, 2014 at 08:10:22AM +0900, Minchan Kim wrote: Hey Joonsoo, On Mon, Sep 29, 2014 at 04:45:27PM +0900, Joonsoo Kim wrote: zsmalloc has many size_classes to reduce fragmentation and they are in 16 bytes unit,

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-09-29 Thread Minchan Kim
Hey Joonsoo, On Mon, Sep 29, 2014 at 04:45:27PM +0900, Joonsoo Kim wrote: > zsmalloc has many size_classes to reduce fragmentation and they are > in 16 bytes unit, for example, 16, 32, 48, etc., if PAGE_SIZE is 4096. > And, zsmalloc has constraint that each zspage has 4 pages at maximum. > > In

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-09-29 Thread Dan Streetman
On Mon, Sep 29, 2014 at 3:45 AM, Joonsoo Kim wrote: > zsmalloc has many size_classes to reduce fragmentation and they are > in 16 bytes unit, for example, 16, 32, 48, etc., if PAGE_SIZE is 4096. > And, zsmalloc has constraint that each zspage has 4 pages at maximum. > > In this situation, we can

[PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-09-29 Thread Joonsoo Kim
zsmalloc has many size_classes to reduce fragmentation and they are in 16 bytes unit, for example, 16, 32, 48, etc., if PAGE_SIZE is 4096. And, zsmalloc has constraint that each zspage has 4 pages at maximum. In this situation, we can see interesting aspect. Let's think about size_class for 1488,

[PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-09-29 Thread Joonsoo Kim
zsmalloc has many size_classes to reduce fragmentation and they are in 16 bytes unit, for example, 16, 32, 48, etc., if PAGE_SIZE is 4096. And, zsmalloc has constraint that each zspage has 4 pages at maximum. In this situation, we can see interesting aspect. Let's think about size_class for 1488,

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-09-29 Thread Dan Streetman
On Mon, Sep 29, 2014 at 3:45 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: zsmalloc has many size_classes to reduce fragmentation and they are in 16 bytes unit, for example, 16, 32, 48, etc., if PAGE_SIZE is 4096. And, zsmalloc has constraint that each zspage has 4 pages at maximum. In this

Re: [PATCH v4] zsmalloc: merge size_class to reduce fragmentation

2014-09-29 Thread Minchan Kim
Hey Joonsoo, On Mon, Sep 29, 2014 at 04:45:27PM +0900, Joonsoo Kim wrote: zsmalloc has many size_classes to reduce fragmentation and they are in 16 bytes unit, for example, 16, 32, 48, etc., if PAGE_SIZE is 4096. And, zsmalloc has constraint that each zspage has 4 pages at maximum. In this