Re: [PATCH v4 06/15] smack: Refactor to remove bprm_secureexec hook

2017-08-01 Thread Casey Schaufler
On 7/31/2017 4:51 PM, Kees Cook wrote: > The Smack bprm_secureexec hook can be merged with the bprm_set_creds > hook since it's dealing with the same information, and all of the details > are finalized during the first call to the bprm_set_creds hook via > prepare_binprm() (subsequent calls due to

Re: [PATCH v4 06/15] smack: Refactor to remove bprm_secureexec hook

2017-08-01 Thread Casey Schaufler
On 7/31/2017 4:51 PM, Kees Cook wrote: > The Smack bprm_secureexec hook can be merged with the bprm_set_creds > hook since it's dealing with the same information, and all of the details > are finalized during the first call to the bprm_set_creds hook via > prepare_binprm() (subsequent calls due to

Re: [PATCH v4 06/15] smack: Refactor to remove bprm_secureexec hook

2017-07-31 Thread James Morris
On Mon, 31 Jul 2017, Kees Cook wrote: > The Smack bprm_secureexec hook can be merged with the bprm_set_creds > hook since it's dealing with the same information, and all of the details > are finalized during the first call to the bprm_set_creds hook via > prepare_binprm() (subsequent calls due to

Re: [PATCH v4 06/15] smack: Refactor to remove bprm_secureexec hook

2017-07-31 Thread James Morris
On Mon, 31 Jul 2017, Kees Cook wrote: > The Smack bprm_secureexec hook can be merged with the bprm_set_creds > hook since it's dealing with the same information, and all of the details > are finalized during the first call to the bprm_set_creds hook via > prepare_binprm() (subsequent calls due to

[PATCH v4 06/15] smack: Refactor to remove bprm_secureexec hook

2017-07-31 Thread Kees Cook
The Smack bprm_secureexec hook can be merged with the bprm_set_creds hook since it's dealing with the same information, and all of the details are finalized during the first call to the bprm_set_creds hook via prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored via

[PATCH v4 06/15] smack: Refactor to remove bprm_secureexec hook

2017-07-31 Thread Kees Cook
The Smack bprm_secureexec hook can be merged with the bprm_set_creds hook since it's dealing with the same information, and all of the details are finalized during the first call to the bprm_set_creds hook via prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored via