Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-25 Thread Zhi Mao
Hi Claudiu, Thanks for your comments. I updated this file, according to your suggestions. Please have a review. Regards Zhi On Tue, 2017-10-24 at 16:25 +0300, m18063 wrote: > Hi Zhi, > > Please see my answer below. > > On 23.10.2017 14:13, Zhi Mao wrote: > > Hi Claudiu > > > > please check

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-25 Thread Zhi Mao
Hi Claudiu, Thanks for your comments. I updated this file, according to your suggestions. Please have a review. Regards Zhi On Tue, 2017-10-24 at 16:25 +0300, m18063 wrote: > Hi Zhi, > > Please see my answer below. > > On 23.10.2017 14:13, Zhi Mao wrote: > > Hi Claudiu > > > > please check

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-24 Thread m18063
Hi Zhi, Please see my answer below. On 23.10.2017 14:13, Zhi Mao wrote: > Hi Claudiu > > please check the comments as below. > > Regards > Zhi > > On Mon, 2017-10-23 at 11:22 +0300, m18063 wrote: >> Hi Zhi, >> >> I have few comments regarding your patch. Please see them below. >> >> Thanks,

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-24 Thread m18063
Hi Zhi, Please see my answer below. On 23.10.2017 14:13, Zhi Mao wrote: > Hi Claudiu > > please check the comments as below. > > Regards > Zhi > > On Mon, 2017-10-23 at 11:22 +0300, m18063 wrote: >> Hi Zhi, >> >> I have few comments regarding your patch. Please see them below. >> >> Thanks,

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-23 Thread Zhi Mao
Hi Claudiu please check the comments as below. Regards Zhi On Mon, 2017-10-23 at 11:22 +0300, m18063 wrote: > Hi Zhi, > > I have few comments regarding your patch. Please see them below. > > Thanks, > Claudiu > > On 22.08.2017 05:09, Zhi Mao wrote: > > Add support to MT2712 and MT7622. > >

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-23 Thread Zhi Mao
Hi Claudiu please check the comments as below. Regards Zhi On Mon, 2017-10-23 at 11:22 +0300, m18063 wrote: > Hi Zhi, > > I have few comments regarding your patch. Please see them below. > > Thanks, > Claudiu > > On 22.08.2017 05:09, Zhi Mao wrote: > > Add support to MT2712 and MT7622. > >

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-23 Thread m18063
Hi Zhi, I have few comments regarding your patch. Please see them below. Thanks, Claudiu On 22.08.2017 05:09, Zhi Mao wrote: > Add support to MT2712 and MT7622. > Due to register offset address of pwm7 for MT2712 is not fixed 0x40, > add mtk_pwm_reg_offset array for pwm register offset. > >

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-23 Thread m18063
Hi Zhi, I have few comments regarding your patch. Please see them below. Thanks, Claudiu On 22.08.2017 05:09, Zhi Mao wrote: > Add support to MT2712 and MT7622. > Due to register offset address of pwm7 for MT2712 is not fixed 0x40, > add mtk_pwm_reg_offset array for pwm register offset. > >

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-22 Thread Zhi Mao
Hi Thierry, Just have a ping on this issue. Regards, Zhi On Wed, 2017-09-20 at 16:48 +0800, Zhi Mao wrote: > Hi Thierry, > > Just a gentle ping on this issue. > Would you please have a review to this patch? > > Regards, > Zhi > > > On Tue, 2017-08-22 at 10:09 +0800, Zhi Mao wrote: > > Add

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-22 Thread Zhi Mao
Hi Thierry, Just have a ping on this issue. Regards, Zhi On Wed, 2017-09-20 at 16:48 +0800, Zhi Mao wrote: > Hi Thierry, > > Just a gentle ping on this issue. > Would you please have a review to this patch? > > Regards, > Zhi > > > On Tue, 2017-08-22 at 10:09 +0800, Zhi Mao wrote: > > Add

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-09-20 Thread Zhi Mao
Hi Thierry, Just a gentle ping on this issue. Would you please have a review to this patch? Regards, Zhi On Tue, 2017-08-22 at 10:09 +0800, Zhi Mao wrote: > Add support to MT2712 and MT7622. > Due to register offset address of pwm7 for MT2712 is not fixed 0x40, > add mtk_pwm_reg_offset array

Re: [PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-09-20 Thread Zhi Mao
Hi Thierry, Just a gentle ping on this issue. Would you please have a review to this patch? Regards, Zhi On Tue, 2017-08-22 at 10:09 +0800, Zhi Mao wrote: > Add support to MT2712 and MT7622. > Due to register offset address of pwm7 for MT2712 is not fixed 0x40, > add mtk_pwm_reg_offset array

[PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-08-21 Thread Zhi Mao
Add support to MT2712 and MT7622. Due to register offset address of pwm7 for MT2712 is not fixed 0x40, add mtk_pwm_reg_offset array for pwm register offset. Signed-off-by: Zhi Mao --- drivers/pwm/pwm-mediatek.c | 51 1 file

[PATCH v4 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-08-21 Thread Zhi Mao
Add support to MT2712 and MT7622. Due to register offset address of pwm7 for MT2712 is not fixed 0x40, add mtk_pwm_reg_offset array for pwm register offset. Signed-off-by: Zhi Mao --- drivers/pwm/pwm-mediatek.c | 51 1 file changed, 42