Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 05:05 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014, Roger Quadros wrote: >> OK. I'll update the binding information to reflect all the clocks. >> >> But what about clk_get() vs of_clk_get_by_name() ? > > I think the convention these days is to just use clk_get(), which

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014, Roger Quadros wrote: > OK. I'll update the binding information to reflect all the clocks. > > But what about clk_get() vs of_clk_get_by_name() ? I think the convention these days is to just use clk_get(), which calls of_clk_get_by_name() internally. Not sure if

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 04:25 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 11:52:44 Sebastian Reichel wrote: >> >> On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: What about the other clocks acquired in drivers/mfd/omap-usb-host.c? Shouldn't all of those be provided

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 04:10 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 15:57:19 Roger Quadros wrote: >> It is a clock gate defined like so in the DT clock data >> >> on OMAP4 >> init_60m_fclk: init_60m_fclk { >> #clock-cells = <0>; >> compatible =

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 11:52:44 Sebastian Reichel wrote: > > On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: > > > What about the other clocks acquired in drivers/mfd/omap-usb-host.c? > > > Shouldn't > > > all of those be provided by via the DT phandle? > > > > All those

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Sebastian Reichel
Hi, On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: > > What about the other clocks acquired in drivers/mfd/omap-usb-host.c? > > Shouldn't > > all of those be provided by via the DT phandle? > > All those clocks are identically named across the OMAP SoCs and are unique > for

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 15:57:19 Roger Quadros wrote: > It is a clock gate defined like so in the DT clock data > > on OMAP4 > init_60m_fclk: init_60m_fclk { > #clock-cells = <0>; > compatible = "ti,divider-clock"; > clocks =

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 03:49 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 15:39:36 Roger Quadros wrote: >>> What about the other clocks acquired in drivers/mfd/omap-usb-host.c? >>> Shouldn't >>> all of those be provided by via the DT phandle? >>> >> >> All those clocks are identically named

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 15:39:36 Roger Quadros wrote: > > What about the other clocks acquired in drivers/mfd/omap-usb-host.c? > > Shouldn't > > all of those be provided by via the DT phandle? > > > > All those clocks are identically named across the OMAP SoCs and are unique > for each >

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
Hi Mark, On 01/08/2014 03:26 PM, Mark Rutland wrote: > On Wed, Jan 08, 2014 at 06:15:38AM +, Roger Quadros wrote: >> The omap-usb-host driver expects the 60MHz functional clock >> of the USB host module to be named as "init_60m_fclk". >> Add this information in the DT binding document. >> >>

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
+Tero Hi Sebastian, On 01/08/2014 02:38 PM, Sebastian Reichel wrote: > On Wed, Jan 08, 2014 at 11:45:38AM +0530, Roger Quadros wrote: >> diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt >> b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt >> index b381fa6..5635202

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Mark Rutland
On Wed, Jan 08, 2014 at 06:15:38AM +, Roger Quadros wrote: > The omap-usb-host driver expects the 60MHz functional clock > of the USB host module to be named as "init_60m_fclk". > Add this information in the DT binding document. > > CC: Lee Jones > CC: Samuel Ortiz > Signed-off-by: Roger

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Sebastian Reichel
On Wed, Jan 08, 2014 at 11:45:38AM +0530, Roger Quadros wrote: > diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt > b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt > index b381fa6..5635202 100644 > --- a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt > +++

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Sebastian Reichel
On Wed, Jan 08, 2014 at 11:45:38AM +0530, Roger Quadros wrote: diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt index b381fa6..5635202 100644 --- a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt +++

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Mark Rutland
On Wed, Jan 08, 2014 at 06:15:38AM +, Roger Quadros wrote: The omap-usb-host driver expects the 60MHz functional clock of the USB host module to be named as init_60m_fclk. Add this information in the DT binding document. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
+Tero Hi Sebastian, On 01/08/2014 02:38 PM, Sebastian Reichel wrote: On Wed, Jan 08, 2014 at 11:45:38AM +0530, Roger Quadros wrote: diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt index b381fa6..5635202 100644

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
Hi Mark, On 01/08/2014 03:26 PM, Mark Rutland wrote: On Wed, Jan 08, 2014 at 06:15:38AM +, Roger Quadros wrote: The omap-usb-host driver expects the 60MHz functional clock of the USB host module to be named as init_60m_fclk. Add this information in the DT binding document. CC: Lee Jones

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 15:39:36 Roger Quadros wrote: What about the other clocks acquired in drivers/mfd/omap-usb-host.c? Shouldn't all of those be provided by via the DT phandle? All those clocks are identically named across the OMAP SoCs and are unique for each SoC, so

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 03:49 PM, Arnd Bergmann wrote: On Wednesday 08 January 2014 15:39:36 Roger Quadros wrote: What about the other clocks acquired in drivers/mfd/omap-usb-host.c? Shouldn't all of those be provided by via the DT phandle? All those clocks are identically named across the OMAP SoCs

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 15:57:19 Roger Quadros wrote: It is a clock gate defined like so in the DT clock data on OMAP4 init_60m_fclk: init_60m_fclk { #clock-cells = 0; compatible = ti,divider-clock; clocks = dpll_usb_m2_ck;

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Sebastian Reichel
Hi, On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: What about the other clocks acquired in drivers/mfd/omap-usb-host.c? Shouldn't all of those be provided by via the DT phandle? All those clocks are identically named across the OMAP SoCs and are unique for each SoC,

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 11:52:44 Sebastian Reichel wrote: On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: What about the other clocks acquired in drivers/mfd/omap-usb-host.c? Shouldn't all of those be provided by via the DT phandle? All those clocks are

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 04:10 PM, Arnd Bergmann wrote: On Wednesday 08 January 2014 15:57:19 Roger Quadros wrote: It is a clock gate defined like so in the DT clock data on OMAP4 init_60m_fclk: init_60m_fclk { #clock-cells = 0; compatible = ti,divider-clock;

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 04:25 PM, Arnd Bergmann wrote: On Wednesday 08 January 2014 11:52:44 Sebastian Reichel wrote: On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: What about the other clocks acquired in drivers/mfd/omap-usb-host.c? Shouldn't all of those be provided by via the DT

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014, Roger Quadros wrote: OK. I'll update the binding information to reflect all the clocks. But what about clk_get() vs of_clk_get_by_name() ? I think the convention these days is to just use clk_get(), which calls of_clk_get_by_name() internally. Not sure if that's

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 05:05 PM, Arnd Bergmann wrote: On Wednesday 08 January 2014, Roger Quadros wrote: OK. I'll update the binding information to reflect all the clocks. But what about clk_get() vs of_clk_get_by_name() ? I think the convention these days is to just use clk_get(), which calls

[PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-07 Thread Roger Quadros
The omap-usb-host driver expects the 60MHz functional clock of the USB host module to be named as "init_60m_fclk". Add this information in the DT binding document. CC: Lee Jones CC: Samuel Ortiz Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/mfd/omap-usb-host.txt | 4

[PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-07 Thread Roger Quadros
The omap-usb-host driver expects the 60MHz functional clock of the USB host module to be named as init_60m_fclk. Add this information in the DT binding document. CC: Lee Jones lee.jo...@linaro.org CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com ---