Re: [PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

В Пт, 24/10/2014 в 17:32 +0800, Wanpeng Li пишет: > Hi Kirill, > 10/24/14, 2:01 PM, Kirill Tkhai: > > Hi, Wanpeng, > > > > the commit commentary confuses, I'm agree. Really it's just a cleanup. > > > > On Пт, 2014-10-24 at 07:27 +0800, Wanpeng Li wrote: > >> Hi Kirill, > >> 8/6/14, 4:06 PM, Kirill

Re: [PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

Hi Kirill, 10/24/14, 2:01 PM, Kirill Tkhai: Hi, Wanpeng, the commit commentary confuses, I'm agree. Really it's just a cleanup. On Пт, 2014-10-24 at 07:27 +0800, Wanpeng Li wrote: Hi Kirill, 8/6/14, 4:06 PM, Kirill Tkhai: (sched_entity::on_rq == 1) does not guarantee the task is pickable;

Re: [PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

Hi, Wanpeng, the commit commentary confuses, I'm agree. Really it's just a cleanup. On Пт, 2014-10-24 at 07:27 +0800, Wanpeng Li wrote: > Hi Kirill, > 8/6/14, 4:06 PM, Kirill Tkhai: > > (sched_entity::on_rq == 1) does not guarantee the task is pickable; > > changes on throttled cfs_rq must not

Re: [PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

Hi, Wanpeng, the commit commentary confuses, I'm agree. Really it's just a cleanup. On Пт, 2014-10-24 at 07:27 +0800, Wanpeng Li wrote: Hi Kirill, 8/6/14, 4:06 PM, Kirill Tkhai: (sched_entity::on_rq == 1) does not guarantee the task is pickable; changes on throttled cfs_rq must not lead to

Re: [PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

Hi Kirill, 10/24/14, 2:01 PM, Kirill Tkhai: Hi, Wanpeng, the commit commentary confuses, I'm agree. Really it's just a cleanup. On Пт, 2014-10-24 at 07:27 +0800, Wanpeng Li wrote: Hi Kirill, 8/6/14, 4:06 PM, Kirill Tkhai: (sched_entity::on_rq == 1) does not guarantee the task is pickable;

Re: [PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

В Пт, 24/10/2014 в 17:32 +0800, Wanpeng Li пишет: Hi Kirill, 10/24/14, 2:01 PM, Kirill Tkhai: Hi, Wanpeng, the commit commentary confuses, I'm agree. Really it's just a cleanup. On Пт, 2014-10-24 at 07:27 +0800, Wanpeng Li wrote: Hi Kirill, 8/6/14, 4:06 PM, Kirill Tkhai:

Re: [PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

Hi Kirill, 8/6/14, 4:06 PM, Kirill Tkhai: (sched_entity::on_rq == 1) does not guarantee the task is pickable; changes on throttled cfs_rq must not lead to reschedule. Why (sched_entity::on_rq == 1) doesn't guarantee the task is pickable since entity will be dequeued during throttling cfs_rq?

Re: [PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

Hi Kirill, 8/6/14, 4:06 PM, Kirill Tkhai: (sched_entity::on_rq == 1) does not guarantee the task is pickable; changes on throttled cfs_rq must not lead to reschedule. Why (sched_entity::on_rq == 1) doesn't guarantee the task is pickable since entity will be dequeued during throttling cfs_rq?

[PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

(sched_entity::on_rq == 1) does not guarantee the task is pickable; changes on throttled cfs_rq must not lead to reschedule. Check for task_struct::on_rq instead. Signed-off-by: Kirill Tkhai --- kernel/sched/fair.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v4 1/6] sched/fair: Fix reschedule which is generated on throttled cfs_rq

(sched_entity::on_rq == 1) does not guarantee the task is pickable; changes on throttled cfs_rq must not lead to reschedule. Check for task_struct::on_rq instead. Signed-off-by: Kirill Tkhai ktk...@parallels.com --- kernel/sched/fair.c |6 +++--- 1 file changed, 3 insertions(+), 3