Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-21 Thread jeffy
Hi Mark, thanks for your reply. On 08/22/2017 01:31 AM, Mark Brown wrote: On Fri, Aug 18, 2017 at 11:03:46PM +0800, jeffy wrote: when using legacy dai naming, the dai->name for rt5514-spi would be the dev name, which is spi2.0 with my local 4.4 kernel, and would be spi32765.0 with upstream

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-21 Thread jeffy
Hi Mark, thanks for your reply. On 08/22/2017 01:31 AM, Mark Brown wrote: On Fri, Aug 18, 2017 at 11:03:46PM +0800, jeffy wrote: when using legacy dai naming, the dai->name for rt5514-spi would be the dev name, which is spi2.0 with my local 4.4 kernel, and would be spi32765.0 with upstream

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-21 Thread Mark Brown
On Fri, Aug 18, 2017 at 11:03:46PM +0800, jeffy wrote: > when using legacy dai naming, the dai->name for rt5514-spi would be the dev > name, which is spi2.0 with my local 4.4 kernel, and would be spi32765.0 with > upstream kernel. It would be better to fix the code to not need a name if the

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-21 Thread Mark Brown
On Fri, Aug 18, 2017 at 11:03:46PM +0800, jeffy wrote: > when using legacy dai naming, the dai->name for rt5514-spi would be the dev > name, which is spi2.0 with my local 4.4 kernel, and would be spi32765.0 with > upstream kernel. It would be better to fix the code to not need a name if the

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-18 Thread jeffy
Hi Mark, On 08/18/2017 07:45 PM, Mark Brown wrote: On Fri, Aug 18, 2017 at 11:11:39AM +0800, Jeffy Chen wrote: Currently we are using devm_snd_soc_register_component, which would use legacy dai naming when dai drv id is zero. Set a non-zero dai drv id to use dai drv name for dai name. Why?

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-18 Thread jeffy
Hi Mark, On 08/18/2017 07:45 PM, Mark Brown wrote: On Fri, Aug 18, 2017 at 11:11:39AM +0800, Jeffy Chen wrote: Currently we are using devm_snd_soc_register_component, which would use legacy dai naming when dai drv id is zero. Set a non-zero dai drv id to use dai drv name for dai name. Why?

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-18 Thread Mark Brown
On Fri, Aug 18, 2017 at 11:11:39AM +0800, Jeffy Chen wrote: > Currently we are using devm_snd_soc_register_component, which would > use legacy dai naming when dai drv id is zero. > > Set a non-zero dai drv id to use dai drv name for dai name. Why? This is clearly not good, we shouldn't be

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-18 Thread Mark Brown
On Fri, Aug 18, 2017 at 11:11:39AM +0800, Jeffy Chen wrote: > Currently we are using devm_snd_soc_register_component, which would > use legacy dai naming when dai drv id is zero. > > Set a non-zero dai drv id to use dai drv name for dai name. Why? This is clearly not good, we shouldn't be

[PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-17 Thread Jeffy Chen
Currently we are using devm_snd_soc_register_component, which would use legacy dai naming when dai drv id is zero. Set a non-zero dai drv id to use dai drv name for dai name. Signed-off-by: Jeffy Chen --- Changes in v4: Use non-zero drv id to avoid legacy dai naming

[PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-17 Thread Jeffy Chen
Currently we are using devm_snd_soc_register_component, which would use legacy dai naming when dai drv id is zero. Set a non-zero dai drv id to use dai drv name for dai name. Signed-off-by: Jeffy Chen --- Changes in v4: Use non-zero drv id to avoid legacy dai naming instead of switching to