Re: [PATCH v4 12/24] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2018-03-20 Thread Wu Hao
On Mon, Mar 19, 2018 at 01:29:52PM -0500, Alan Tull wrote: > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > Hi Hao, > > Looking at fpga-dfl.h again, there's a lot of things that start with > FPGA_. Don't you think this is too general? There are other FPGA_ > things in

Re: [PATCH v4 12/24] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2018-03-20 Thread Wu Hao
On Mon, Mar 19, 2018 at 01:29:52PM -0500, Alan Tull wrote: > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > Hi Hao, > > Looking at fpga-dfl.h again, there's a lot of things that start with > FPGA_. Don't you think this is too general? There are other FPGA_ > things in the kernel. Not

Re: [PATCH v4 12/24] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2018-03-19 Thread Alan Tull
On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: Hi Hao, Looking at fpga-dfl.h again, there's a lot of things that start with FPGA_. Don't you think this is too general? There are other FPGA_ things in the kernel. Not just the things added by this patch, but the whole file.

Re: [PATCH v4 12/24] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2018-03-19 Thread Alan Tull
On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: Hi Hao, Looking at fpga-dfl.h again, there's a lot of things that start with FPGA_. Don't you think this is too general? There are other FPGA_ things in the kernel. Not just the things added by this patch, but the whole file. >

[PATCH v4 12/24] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2018-02-13 Thread Wu Hao
FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which need to be supported by all feature devices drivers including FME and AFU. Userspace application can use these ioctl interfaces to get the API info and check if specific extension is supported or not in current driver.

[PATCH v4 12/24] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2018-02-13 Thread Wu Hao
FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which need to be supported by all feature devices drivers including FME and AFU. Userspace application can use these ioctl interfaces to get the API info and check if specific extension is supported or not in current driver.