Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-15 Thread Sathyanarayanan Kuppuswamy Natarajan
On Wed, Oct 14, 2020 at 11:43 PM Christoph Hellwig wrote: > > On Tue, Oct 13, 2020 at 08:17:39AM -0700, Kuppuswamy, Sathyanarayanan wrote: > > > > > > On 10/13/20 4:56 AM, Christoph Hellwig wrote: > > > You might want to split out pcie_do_fatal_recovery and get rid of the > > > state argument: >

Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-15 Thread Christoph Hellwig
On Tue, Oct 13, 2020 at 08:17:39AM -0700, Kuppuswamy, Sathyanarayanan wrote: > > > On 10/13/20 4:56 AM, Christoph Hellwig wrote: > > You might want to split out pcie_do_fatal_recovery and get rid of the > > state argument: > This is how it was before Keith merged fatal and non-fatal error

Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-14 Thread Ethan Zhao
On Mon, Oct 12, 2020 at 1:10 PM wrote: > > From: Kuppuswamy Sathyanarayanan > > Commit bdb5ac85777d ("PCI/ERR: Handle fatal error recovery") > merged fatal and non-fatal error recovery paths, and also made > recovery code depend on hotplug handler for "remove affected > device + rescan" support.

Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-13 Thread Kuppuswamy, Sathyanarayanan
On 10/13/20 10:44 PM, Ethan Zhao wrote: This patch only reverts the commit bdb5ac85777d ? or you'd better separate the revert and code you added. We cannot revert the commit as it is. pcie_do_recovery() function and Documentation/* folder changed a lot since fatal and non-fatal error

Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-13 Thread Kuppuswamy, Sathyanarayanan
On 10/13/20 4:56 AM, Christoph Hellwig wrote: You might want to split out pcie_do_fatal_recovery and get rid of the state argument: This is how it was before Keith merged fatal and non-fatal error recovery paths. When the comparison is between additional-parameter vs new-interface , I choose

Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-13 Thread Christoph Hellwig
You might want to split out pcie_do_fatal_recovery and get rid of the state argument: diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index fa12f7cbc1a095..eec0d3fe9fd967 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -556,7 +556,8 @@ static inline int

Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-12 Thread Sinan Kaya
On 10/12/2020 1:03 AM, sathyanarayanan.nkuppusw...@gmail.com wrote: > From: Kuppuswamy Sathyanarayanan > > Commit bdb5ac85777d ("PCI/ERR: Handle fatal error recovery") > merged fatal and non-fatal error recovery paths, and also made > recovery code depend on hotplug handler for "remove affected

[PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-11 Thread sathyanarayanan . nkuppuswamy
From: Kuppuswamy Sathyanarayanan Commit bdb5ac85777d ("PCI/ERR: Handle fatal error recovery") merged fatal and non-fatal error recovery paths, and also made recovery code depend on hotplug handler for "remove affected device + rescan" support. But this change also complicated the error recovery