Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-17 Thread Stephen Warren
On 01/16/2013 10:03 PM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Wed, 16 Jan 2013 21:11:24 > +0100: > +static int clk_frac_div_set_rate(struct clk_hw *hw, unsigned long rate, + unsigned long parent_rate) +{ + struct tegra_clk_frac_div

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-17 Thread Stephen Warren
On 01/16/2013 10:03 PM, Hiroshi Doyu wrote: Stephen Warren swar...@wwwdotorg.org wrote @ Wed, 16 Jan 2013 21:11:24 +0100: +static int clk_frac_div_set_rate(struct clk_hw *hw, unsigned long rate, + unsigned long parent_rate) +{ + struct

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Hiroshi Doyu
Stephen Warren wrote @ Wed, 16 Jan 2013 21:11:24 +0100: > >> +static int clk_frac_div_set_rate(struct clk_hw *hw, unsigned long rate, > >> + unsigned long parent_rate) > >> +{ > >> + struct tegra_clk_frac_div *divider = to_clk_frac_div(hw); > >> + int

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Stephen Warren
On 01/16/2013 08:12 AM, Hiroshi Doyu wrote: > Prashant Gaikwad wrote @ Fri, 11 Jan 2013 08:46:20 > +0100: > > >> diff --git a/drivers/clk/tegra/clk-audio-sync.c >> b/drivers/clk/tegra/clk-audio-sync.c >> +#define to_clk_sync_source(_hw)\ >> +

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Stephen Warren
On 01/16/2013 05:31 AM, Hiroshi Doyu wrote: > Prashant Gaikwad wrote @ Fri, 11 Jan 2013 08:46:20 > +0100: > ... >> +struct clk *tegra_clk_periph(const char *name, const char **parent_names, >> +int num_parents, struct tegra_clk_periph >> *periph, >> +

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Stephen Warren
On 01/16/2013 01:19 AM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Fri, 11 Jan 2013 22:35:28 > +0100: > >> On 01/11/2013 04:48 AM, Hiroshi Doyu wrote: >>> Hi Prahant, >>> >>> Some nit-pick/cosmetic comments inlined... >> >> FYI, Prashant is on vacation for the next week or two, so I'll take

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Hiroshi Doyu
Prashant Gaikwad wrote @ Fri, 11 Jan 2013 08:46:20 +0100: > diff --git a/drivers/clk/tegra/clk-audio-sync.c > b/drivers/clk/tegra/clk-audio-sync.c > new file mode 100644 > index 000..bb2fe43 > --- /dev/null > +++ b/drivers/clk/tegra/clk-audio-sync.c > @@ -0,0 +1,89 @@ > +/* > + *

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Hiroshi Doyu
Prashant Gaikwad wrote @ Fri, 11 Jan 2013 08:46:20 +0100: ... > +const struct clk_ops tegra_clk_periph_ops = { > + .get_parent = clk_periph_get_parent, > + .set_parent = clk_periph_set_parent, > + .recalc_rate = clk_periph_recalc_rate, > + .round_rate =

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Hiroshi Doyu
Stephen Warren wrote @ Fri, 11 Jan 2013 22:35:28 +0100: > On 01/11/2013 04:48 AM, Hiroshi Doyu wrote: > > Hi Prahant, > > > > Some nit-pick/cosmetic comments inlined... > > FYI, Prashant is on vacation for the next week or two, so I'll take over > this series to clean up any last review

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Hiroshi Doyu
Stephen Warren swar...@wwwdotorg.org wrote @ Fri, 11 Jan 2013 22:35:28 +0100: On 01/11/2013 04:48 AM, Hiroshi Doyu wrote: Hi Prahant, Some nit-pick/cosmetic comments inlined... FYI, Prashant is on vacation for the next week or two, so I'll take over this series to clean up any last

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Hiroshi Doyu
Prashant Gaikwad pgaik...@nvidia.com wrote @ Fri, 11 Jan 2013 08:46:20 +0100: ... +const struct clk_ops tegra_clk_periph_ops = { + .get_parent = clk_periph_get_parent, + .set_parent = clk_periph_set_parent, + .recalc_rate = clk_periph_recalc_rate, + .round_rate =

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Hiroshi Doyu
Prashant Gaikwad pgaik...@nvidia.com wrote @ Fri, 11 Jan 2013 08:46:20 +0100: diff --git a/drivers/clk/tegra/clk-audio-sync.c b/drivers/clk/tegra/clk-audio-sync.c new file mode 100644 index 000..bb2fe43 --- /dev/null +++ b/drivers/clk/tegra/clk-audio-sync.c @@ -0,0 +1,89 @@ +/*

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Stephen Warren
On 01/16/2013 01:19 AM, Hiroshi Doyu wrote: Stephen Warren swar...@wwwdotorg.org wrote @ Fri, 11 Jan 2013 22:35:28 +0100: On 01/11/2013 04:48 AM, Hiroshi Doyu wrote: Hi Prahant, Some nit-pick/cosmetic comments inlined... FYI, Prashant is on vacation for the next week or two, so I'll

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Stephen Warren
On 01/16/2013 05:31 AM, Hiroshi Doyu wrote: Prashant Gaikwad pgaik...@nvidia.com wrote @ Fri, 11 Jan 2013 08:46:20 +0100: ... +struct clk *tegra_clk_periph(const char *name, const char **parent_names, +int num_parents, struct tegra_clk_periph *periph, +

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Stephen Warren
On 01/16/2013 08:12 AM, Hiroshi Doyu wrote: Prashant Gaikwad pgaik...@nvidia.com wrote @ Fri, 11 Jan 2013 08:46:20 +0100: diff --git a/drivers/clk/tegra/clk-audio-sync.c b/drivers/clk/tegra/clk-audio-sync.c +#define to_clk_sync_source(_hw)\

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-16 Thread Hiroshi Doyu
Stephen Warren swar...@wwwdotorg.org wrote @ Wed, 16 Jan 2013 21:11:24 +0100: +static int clk_frac_div_set_rate(struct clk_hw *hw, unsigned long rate, + unsigned long parent_rate) +{ + struct tegra_clk_frac_div *divider = to_clk_frac_div(hw); +

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-13 Thread Sivaram Nair
On Fri, Jan 11, 2013 at 08:46:20AM +0100, Prashant Gaikwad wrote: > +static int _program_pll(struct clk_hw *hw, struct tegra_clk_pll_freq_table > *cfg, > + unsigned long rate) > +{ > + struct tegra_clk_pll *pll = to_clk_pll(hw); > + unsigned long flags = 0; > +

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-13 Thread Sivaram Nair
On Fri, Jan 11, 2013 at 08:46:20AM +0100, Prashant Gaikwad wrote: +static int _program_pll(struct clk_hw *hw, struct tegra_clk_pll_freq_table *cfg, + unsigned long rate) +{ + struct tegra_clk_pll *pll = to_clk_pll(hw); + unsigned long flags = 0; +

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-11 Thread Stephen Warren
On 01/11/2013 04:48 AM, Hiroshi Doyu wrote: > Hi Prahant, > > Some nit-pick/cosmetic comments inlined... FYI, Prashant is on vacation for the next week or two, so I'll take over this series to clean up any last review comments. > Prashant Gaikwad wrote @ Fri, 11 Jan 2013 08:46:20 > +0100: >

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-11 Thread Hiroshi Doyu
Hi Prahant, Some nit-pick/cosmetic comments inlined... Prashant Gaikwad wrote @ Fri, 11 Jan 2013 08:46:20 +0100: > Add tegra specific clocks, pll, pll_out, peripheral, > frac_divider, super. > > Signed-off-by: Prashant Gaikwad > --- > drivers/clk/Makefile|1 + >

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-11 Thread Hiroshi Doyu
Hi Prahant, Some nit-pick/cosmetic comments inlined... Prashant Gaikwad pgaik...@nvidia.com wrote @ Fri, 11 Jan 2013 08:46:20 +0100: Add tegra specific clocks, pll, pll_out, peripheral, frac_divider, super. Signed-off-by: Prashant Gaikwad pgaik...@nvidia.com --- drivers/clk/Makefile

Re: [PATCH v4 2/9] clk: tegra: Add tegra specific clocks

2013-01-11 Thread Stephen Warren
On 01/11/2013 04:48 AM, Hiroshi Doyu wrote: Hi Prahant, Some nit-pick/cosmetic comments inlined... FYI, Prashant is on vacation for the next week or two, so I'll take over this series to clean up any last review comments. Prashant Gaikwad pgaik...@nvidia.com wrote @ Fri, 11 Jan 2013