ubject: Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support
>
> On Tue, Sep 03, 2013 at 05:43:21AM +, Lu Jingchang-B35083 wrote:
> > Do you mean the DMA_SLAVE_CONFIG device_control? Yeah, the slave
> driver could pass
> > the slave_id. But the DMA
] dma: Add Freescale eDMA engine driver support
On Tue, Sep 03, 2013 at 05:43:21AM +, Lu Jingchang-B35083 wrote:
Do you mean the DMA_SLAVE_CONFIG device_control? Yeah, the slave
driver could pass
the slave_id. But the DMA_SLAVE_CONFIG may be called more than once,
and the eDMA
driver
ubject: Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support
>
> On Tue, Sep 03, 2013 at 05:43:21AM +, Lu Jingchang-B35083 wrote:
> > Do you mean the DMA_SLAVE_CONFIG device_control? Yeah, the slave
> driver could pass
> > the slave_id. But the DMA
On Tue, Sep 03, 2013 at 05:43:21AM +, Lu Jingchang-B35083 wrote:
> Do you mean the DMA_SLAVE_CONFIG device_control? Yeah, the slave driver
> could pass
> the slave_id. But the DMA_SLAVE_CONFIG may be called more than once, and the
> eDMA
> driver just needs to set the slave id once for any
] dma: Add Freescale eDMA engine driver support
On Tue, Sep 03, 2013 at 05:43:21AM +, Lu Jingchang-B35083 wrote:
Do you mean the DMA_SLAVE_CONFIG device_control? Yeah, the slave
driver could pass
the slave_id. But the DMA_SLAVE_CONFIG may be called more than once,
and the eDMA
driver
On Tue, Sep 03, 2013 at 05:43:21AM +, Lu Jingchang-B35083 wrote:
Do you mean the DMA_SLAVE_CONFIG device_control? Yeah, the slave driver
could pass
the slave_id. But the DMA_SLAVE_CONFIG may be called more than once, and the
eDMA
driver just needs to set the slave id once for any
> > How about change the filter_fn to follow:
> > static bool fsl_edma_filter_fn(struct dma_chan *chan, void *fn_param)
> > {
> > struct fsl_edma_filter_param *fparam = fn_param;
> > struct fsl_edma_chan *fsl_chan = to_fsl_edma_chan(chan);
> > unsigned char val;
> >
> >
On Mon, Sep 02, 2013 at 07:32:53AM +, Lu Jingchang-B35083 wrote:
> > > > > > > + chan->private = fn_param;
> > > > > > why do you need to use chan->private?
> > > > > [Lu Jingchang]
> > > > > The private used here is to store the slot_id information, which
> > must
> > > > be used
> > > > > by
, 2013 12:51 PM
> > > To: Lu Jingchang-B35083
> > > Cc: shawn@linaro.org; linux-kernel@vger.kernel.org; linux-arm-
> > > ker...@lists.infradead.org; devicet...@vger.kernel.org
> > > Subject: Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver
nel@vger.kernel.org; linux-arm-
> > ker...@lists.infradead.org; devicet...@vger.kernel.org
> > Subject: Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support
> >
> > On Thu, Aug 29, 2013 at 03:32:04AM +, Lu Jingchang-B35083 wrote:
> >
> > Please use
ubject: Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support
>
> On Thu, Aug 29, 2013 at 03:32:04AM +, Lu Jingchang-B35083 wrote:
>
> Please use a right MUA and wrap your lines at 80chars...
>
> >
> >
] dma: Add Freescale eDMA engine driver support
On Thu, Aug 29, 2013 at 03:32:04AM +, Lu Jingchang-B35083 wrote:
Please use a right MUA and wrap your lines at 80chars...
+ return -EINVAL;
+ }
+ return 0
...@lists.infradead.org; devicet...@vger.kernel.org
Subject: Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support
On Thu, Aug 29, 2013 at 03:32:04AM +, Lu Jingchang-B35083 wrote:
Please use a right MUA and wrap your lines at 80chars...
[Lu Jingchang]
No need to put your
; linux-kernel@vger.kernel.org; linux-arm-
ker...@lists.infradead.org; devicet...@vger.kernel.org
Subject: Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver
support
On Thu, Aug 29, 2013 at 03:32:04AM +, Lu Jingchang-B35083 wrote:
Please use a right MUA and wrap your lines
On Mon, Sep 02, 2013 at 07:32:53AM +, Lu Jingchang-B35083 wrote:
+ chan-private = fn_param;
why do you need to use chan-private?
[Lu Jingchang]
The private used here is to store the slot_id information, which
must
be used
by the DMAMUX in alloc_chan_resources
How about change the filter_fn to follow:
static bool fsl_edma_filter_fn(struct dma_chan *chan, void *fn_param)
{
struct fsl_edma_filter_param *fparam = fn_param;
struct fsl_edma_chan *fsl_chan = to_fsl_edma_chan(chan);
unsigned char val;
if
On Thu, Aug 29, 2013 at 03:32:04AM +, Lu Jingchang-B35083 wrote:
Please use a right MUA and wrap your lines at 80chars...
>
> >
> > > + return -EINVAL;
> > > + }
> > > + return 0;
> > > +
> > > + default:
> > > + return -ENXIO;
> > > + }
> > > +}
> >
On Thu, Aug 29, 2013 at 03:32:04AM +, Lu Jingchang-B35083 wrote:
Please use a right MUA and wrap your lines at 80chars...
+ return -EINVAL;
+ }
+ return 0;
+
+ default:
+ return -ENXIO;
+ }
+}
+
+static enum
> > + } else {
> since you support cyclic, is there a reasonw why you dont support
> pause/resume?
> is it hw issue or planned in future?
[Lu Jingchang]
The HW supports start/stop request from the peripheral dma request, I had
planned to add this in future as requested.
I will add this
On Fri, Aug 16, 2013 at 02:07:54PM +0800, Jingchang Lu wrote:
> Add Freescale enhanced direct memory(eDMA) controller support.
> The eDMA controller deploys DMAMUXs routing DMA request sources(slot)
> to eDMA channels.
> This module can be found on Vybrid and LS-1 SoCs.
>
+
@linaro.org; linux-kernel@vger.kernel.org;
> linux-arm-ker...@lists.infradead.org; Lu Jingchang-B35083; Wang Huan-
> B18965
> Subject: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support
>
> Add Freescale enhanced direct memory(eDMA) controller support.
> The eDMA c
; linux-kernel@vger.kernel.org;
linux-arm-ker...@lists.infradead.org; Lu Jingchang-B35083; Wang Huan-
B18965
Subject: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support
Add Freescale enhanced direct memory(eDMA) controller support.
The eDMA controller deploys DMAMUXs routing DMA request
On Fri, Aug 16, 2013 at 02:07:54PM +0800, Jingchang Lu wrote:
Add Freescale enhanced direct memory(eDMA) controller support.
The eDMA controller deploys DMAMUXs routing DMA request sources(slot)
to eDMA channels.
This module can be found on Vybrid and LS-1 SoCs.
+ devicet...@vger.kernel.org,
+ } else {
since you support cyclic, is there a reasonw why you dont support
pause/resume?
is it hw issue or planned in future?
[Lu Jingchang]
The HW supports start/stop request from the peripheral dma request, I had
planned to add this in future as requested.
I will add this in
Add Freescale enhanced direct memory(eDMA) controller support.
The eDMA controller deploys DMAMUXs routing DMA request sources(slot)
to eDMA channels.
This module can be found on Vybrid and LS-1 SoCs.
Signed-off-by: Alison Wang
Signed-off-by: Jingchang Lu
---
changes in v4:
using exact
Add Freescale enhanced direct memory(eDMA) controller support.
The eDMA controller deploys DMAMUXs routing DMA request sources(slot)
to eDMA channels.
This module can be found on Vybrid and LS-1 SoCs.
Signed-off-by: Alison Wang b18...@freescale.com
Signed-off-by: Jingchang Lu b35...@freescale.com
26 matches
Mail list logo
