Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-19 Thread Simon Glass
Hi, On Tue, Feb 19, 2013 at 12:36 AM, li guang wrote: > 在 2013-02-15五的 20:16 -0800，Simon Glass写道： >> Use the key-matrix layer to interpret key scan information from the EC >> and inject input based on the FDT-supplied key map. This driver registers >> itself with the ChromeOS EC driver to

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-19 Thread li guang
在 2013-02-15五的 20:16 -0800，Simon Glass写道： > Use the key-matrix layer to interpret key scan information from the EC > and inject input based on the FDT-supplied key map. This driver registers > itself with the ChromeOS EC driver to perform communications. [snip ...] > +/* > + * Returns true when

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-19 Thread Dmitry Torokhov
On Mon, Feb 18, 2013 at 11:20:43PM -0800, Joe Perches wrote: > On Mon, 2013-02-18 at 20:13 -0800, Simon Glass wrote: > > On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov > > > On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: > > >> + for (row = 0; row < ckdev->rows; row++) { > >

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-19 Thread Dmitry Torokhov
On Mon, Feb 18, 2013 at 11:20:43PM -0800, Joe Perches wrote: On Mon, 2013-02-18 at 20:13 -0800, Simon Glass wrote: On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: + for (row = 0; row ckdev-rows; row++) { +

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-19 Thread li guang
在 2013-02-15五的 20:16 -0800，Simon Glass写道： Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC driver to perform communications. [snip ...] +/* + * Returns true when there

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-19 Thread Simon Glass
Hi, On Tue, Feb 19, 2013 at 12:36 AM, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-02-15五的 20:16 -0800，Simon Glass写道： Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-18 Thread Joe Perches
On Mon, 2013-02-18 at 20:13 -0800, Simon Glass wrote: > On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov > > On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: > >> + for (row = 0; row < ckdev->rows; row++) { > >> + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) >

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-18 Thread Simon Glass
Hi Dmitry, On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov wrote: > Hi Simon, > > On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: >> + for (row = 0; row < ckdev->rows; row++) { >> + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) >> + return

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-18 Thread Simon Glass
Hi Dmitry, On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Simon, On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: + for (row = 0; row ckdev-rows; row++) { + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) +

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-18 Thread Joe Perches
On Mon, 2013-02-18 at 20:13 -0800, Simon Glass wrote: On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: + for (row = 0; row ckdev-rows; row++) { + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) +

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-16 Thread Dmitry Torokhov
Hi Simon, On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: > + for (row = 0; row < ckdev->rows; row++) { > + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) > + return true; > + } No need for curly braces here. I would not care if not for

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-16 Thread Dmitry Torokhov
Hi Simon, On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: + for (row = 0; row ckdev-rows; row++) { + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) + return true; + } No need for curly braces here. I would not care if not for below.

[PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-15 Thread Simon Glass
Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC driver to perform communications. The matrix-keypad FDT binding is used with a small addition to control ghosting.

[PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-15 Thread Simon Glass
Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC driver to perform communications. The matrix-keypad FDT binding is used with a small addition to control ghosting.