Re: [PATCH v4 8/9] phy: Add Cadence D-PHY support

2019-01-21 Thread Maxime Ripard
Hi Sean, On Thu, Jan 17, 2019 at 08:53:22AM -0500, Sean Paul wrote: > On Wed, Jan 09, 2019 at 10:33:25AM +0100, Maxime Ripard wrote: > > + opts->wakeup = cdns_dphy_get_wakeup_time_ns(dphy) * 1000; > > This should be "/ 1000" since the units of wakeup is us now (thanks to patch > 2). > You've

Re: [PATCH v4 8/9] phy: Add Cadence D-PHY support

2019-01-17 Thread Sean Paul
On Wed, Jan 09, 2019 at 10:33:25AM +0100, Maxime Ripard wrote: > Cadence has designed a D-PHY that can be used by the, currently in tree, > DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers. > > Only the DSI driver has an ad-hoc driver for that phy at the moment, while > the v4l2

Re: [PATCH v4 8/9] phy: Add Cadence D-PHY support

2019-01-09 Thread Sakari Ailus
On Wed, Jan 09, 2019 at 10:33:25AM +0100, Maxime Ripard wrote: > Cadence has designed a D-PHY that can be used by the, currently in tree, > DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers. > > Only the DSI driver has an ad-hoc driver for that phy at the moment, while > the v4l2

[PATCH v4 8/9] phy: Add Cadence D-PHY support

2019-01-09 Thread Maxime Ripard
Cadence has designed a D-PHY that can be used by the, currently in tree, DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers. Only the DSI driver has an ad-hoc driver for that phy at the moment, while the v4l2 drivers are completely missing any phy support. In order to make that phy